✨(backends) add support for the AWS S3 backend #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
3 times, most recently
from
3b4950c
to
029679b
Compare
jmaupetit
reviewed
Sep 15, 2022
tests/backends/storage/test_s3.py
Outdated
Comment on lines
64
to
68
| # Fix for incompatibility between moto and pyfakefs | ||
| # See https://github.com/spulec/moto/issues/1682 | ||
| for module in [boto3, botocore]: | ||
| module_dir = Path(module.__file__).parent | ||
| fs.add_real_directory(module_dir, lazy_read=False) |
There was a problem hiding this comment.
Have you tried to factor this in the test suite setup() function?
There was a problem hiding this comment.
The fs pyfakefs plugin from pytest has a function scope. Best I can do is factoring the code in a function scope fixture, but the fixture still needs to be called for each test method where moto and fs are used together. Pytest has fs_module or fs_session with larger scopes, but you can only choose one of the three, so it would have an impact on many tests.
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
from
029679b
to
cc26794
Compare
wilbrdt
changed the title
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
from
cc26794
to
63e52ae
Compare
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
2 times, most recently
from
e7b5961
to
9594c70
Compare
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
2 times, most recently
from
17d392c
to
6139c13
Compare
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
5 times, most recently
from
4e5f32d
to
e7fe2fb
Compare
jmaupetit
reviewed
Dec 15, 2022
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
2 times, most recently
from
77e7ad5
to
e4002b0
Compare
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
5 times, most recently
from
9671b22
to
6a0f0f7
Compare
Implement s3 backend using low-level interface client from the boto3 library
Fix pydocstyle linter now processing all src files and fix linter warnings.
wilbrdt
force-pushed
the
add-aws-s3-backend
branch
from
6a0f0f7
to
3199baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Following issue #75, this PR aims to implement a new s3 backend using the low-level interface "client" from the boto3 library.
Proposal