Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect course search links with different courses parent page and search page #1810

Closed
igobranco opened this issue Oct 24, 2022 · 2 comments
Assignees
Labels

Comments

@igobranco
Copy link
Collaborator

Bug Report

Issues when Richie is configured with different pages, one for the course parent page and another for the search page.

On NAU we have the /en/courses page, that allows to search the courses, but the parent courses page is the /en/course. This second page has the id courses, so Richie knows where to put the newer course pages, and it redirect to the first /en/courses page.

We have configured this because, this was how our older marketing site works. And it seems to be working fine.
Recently we have found an issue, that the organization detail page, categories page, etc, are refering to the correct courses page search. They are refering the /en/course page with additional query parameters. But the redirect on the page lost the query parameters.
So for the user, when he goes to the organization page and clicks to view all the courses for that organization, it's lost the organization filter during the redirect.

I think that the major issue is that Richie has 2 different concepts mixed toogether:

  1. the search page
  2. the parent course page
    On a simpler solution both could be the same page, but I think Richie should allow different configurations. For example the search could evolve to search more stuff, like programs and not only courses.

Possible Solution

Add a new Django setting that allow to change the courses search reverse id.

@igobranco igobranco self-assigned this Oct 24, 2022
igobranco added a commit to igobranco/richie that referenced this issue Oct 24, 2022
Add `RICHIE_SEARCH_REVERSE_ID` setting that allows to have different
search page and courses parent page.
Closes openfun#1810
igobranco added a commit to igobranco/richie that referenced this issue Oct 24, 2022
Add `RICHIE_SEARCH_REVERSE_ID` setting that allows to have different
search page and courses parent page.
Closes openfun#1810
igobranco added a commit to igobranco/richie that referenced this issue Oct 24, 2022
Add `RICHIE_SEARCH_REVERSE_ID` setting that allows to have different
search page and courses parent page.
Closes openfun#1810
igobranco added a commit to fccn/nau_playbooks that referenced this issue Oct 24, 2022
On Richie stack add a temporary fix that on nginx level redirects to
course search preserving the query parameters.
GN-996
openfun/richie#1810
@jbpenrath jbpenrath added the bug label Oct 26, 2022
@igobranco
Copy link
Collaborator Author

This issue is being "fixed" directly on Django CMS django-cms/django-cms#7489

@igobranco
Copy link
Collaborator Author

The PR django-cms/django-cms#7489 has been merged to the develop branch, so we need to wait for the new release of django-cms and its upgrade on Richie.
Given that this issue is specific to NAU installation, I think that the new CMS_REDIRECT_PRESERVE_QUERY_PARAMS setting (that fix this issue) doesn't need to be enabled by default on Richie.
Closing this issue.

@igobranco igobranco closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants