Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker user for development #279

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Fix docker user for development #279

merged 3 commits into from
Jul 4, 2018

Commits on Jul 4, 2018

  1. 🐳(makefile) use local user id to run commands 

    To avoid permission issues during development, we enforce the docker
user ID to match the local user ID that is running docker commands. By
doing so, new files created in local volumes will belong the local user
instead of root:root.

Nota bene:

* this Makefile should only be use for development
* our user id enforcement only works for commands launched thanks to
  this Makefile
    @jmaupetit
    jmaupetit committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    0a881ee View commit details
    Browse the repository at this point in the history

  2. 🐳(scripts) add sugar script to ease user override 

    * Add sugar scripts to ease running docker run and docker exec commands
  with the appropriate user ID (matching the local user ID)
* Improve log messages with emojis 🎉
    @jmaupetit
    jmaupetit committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    a050bdf View commit details
    Browse the repository at this point in the history

  3. 📝(docker) add docs about our sugar scripts 

    Add documentation about sugar scripts usage and mention them in the
README.
    @jmaupetit
    jmaupetit committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    9b0d8d9 View commit details
    Browse the repository at this point in the history