🐛(docker) use local user ID in the dev image #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
added
needs review
bug
FUN Team
Richie's development image can now be built using a user ID passed as a build argument. This allows us to run commands with this default user when starting the docker-compose app service and prevent permission issues with mounted volumes belonging to the local user. Fix #305
jmaupetit
force-pushed
the
fix-compose-user
branch
from
b4a6679
to
b296eed
Compare
sampaccoud
approved these changes
Jul 26, 2018
| # passing a build argument to your build command, e.g.: | ||
| # passing the BASE_TAG build argument to your build command. You can also | ||
| # override the default container running user ID (e.g. 1000) thanks to the UID | ||
| # build argument (we recommend using yours). An example follows: |
There was a problem hiding this comment.
Should be called USER (or USER_ID)? Not sure UID is explicit and the param in Dockerfile is called USER.
There was a problem hiding this comment.
It refers to the UID shell variable. I thought it was explicit...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When starting the development stack using the
docker-compose upcommand, compose uses the image defaultUSERto run defined command (e.g.10000in the "dev" Dockerfile). Hence the Django development server runs using this user ID. This is an issue when developing with local volumes mounted in this container, because, the server may want to create new files in these volumes and unfortunately the running user (with UID10000) has no permission to write in the aforementioned volumes.Proposal
UIDbuildARGto be able to customize the default user ID in the "dev" docker imageFix #305