WIP: ✅(demo) improve demo site page tree #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveetch
force-pushed
the
demo_new_page_tree
branch
from
a87f8fe
to
7b4fafb
Compare
sampaccoud
reviewed
Sep 3, 2018
| @@ -26,6 +26,7 @@ | |||
|
|
|||
| logger = logging.getLogger("richie.commands.core.create_demo_site") | |||
|
|
|||
| DEMO_ANNEXE_PAGE_ID = "annexe" | |||
There was a problem hiding this comment.
make it "annex" in english so:
ANNEX_PAGE_ID = "annex"
| @@ -111,28 +130,59 @@ def clear_cms_data(): | |||
| Person.objects.all().delete() | |||
|
|
|||
|
|
|||
| def create_demo_site(): | |||
| def recursive_page_creation(site, pages, parent=None): | |||
There was a problem hiding this comment.
I think it is becoming too complicated for just one child page, and you have created empty pages so the final solution where you add content to each page will not look like this...
For the moment, maybe just add this to the create_demo_site method:
languages=[l[0] for l in settings.LANGUAGES]
about_page = create_i18n_page(
languages=languages,
parent=pages_created["annex"],
published=True,
)
create_text_plugin(
about_page,
"main_content",
languages=languages,
)
7b4fafb
to
889b34d
Compare
sampaccoud
reviewed
Sep 4, 2018
src/richie/apps/core/factories.py
Outdated
| @@ -79,6 +79,16 @@ def _after_postgeneration(cls, instance, create, results=None): | |||
| for language in instance.extended_object.get_languages(): | |||
| instance.extended_object.publish(language) | |||
|
|
|||
| @factory.post_generation | |||
| # pylint: disable=no-self-use,unused-argument | |||
| def in_navigation(self, create, extracted, **kwargs): | |||
There was a problem hiding this comment.
You can just modify the existing method "extended_object" like so:
@factory.lazy_attribute
def extended_object(self):
return create_i18n_page(
title=self.title,
languages=self.languages,
template=self.template,
in_navigation=self.in_navigation,
parent=self.parent,
)
Page tree is just a flat list of pages, all enabled in navigation. But we don't want every pages to be in menus and need a more advanced architecture to be able to create an additional menu for annexe page like About, Help, Legal mentions, etc.. This commit hides some pages from menus and add a new page "Annexe" where "About" page is moved in.
sveetch
force-pushed
the
demo_new_page_tree
branch
from
889b34d
to
5461ee2
Compare
sampaccoud
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Page tree is just a flat list of pages, all enabled in navigation.
But we don't want every pages to be in menus and need a more advanced
architecture to be able to create an additional menu for annexe page
like About, Help, Legal mentions, etc..
Proposal
This commit hides some pages from menus and add a new page "Annexe"
where "About" page is moved in.