Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
packages: Use device overlay instead of GoogleWebViewOverlay on SDK<=28.
Reports from Android 9 users indicate that `dumpsys webviewupdate` does not contain any of the webviews listed in GoogleWebViewOverlay despite the overlay being statically enabled according to `dumpsys overlay`, and it containing the xml file with expected nodes when inspected with `aapt2 dump xmltree --file res/xml/config_webview_packages.xml`. A quick check confirms that the last Android 9 crosshatch system image includes res/xml/config_webview_packages.xml directly in /system/framework/framework-res.apk instead of through a separate overlay APK. This, together with the fact that the overlay isn't properly applied even when residing in /system/overlay/ leads to believe that the specific <webviewproviders> xml does not get overlaid, or at least incorrectly. However: DEVICE_PACKAGE_OVERLAYS causes the overlaid files to end up in an autogenerated RRO in device trees that declare `framework-res` (or the wildcard `*`) in PRODUCT_ENFORCE_RRO_TARGETS. The xml from this overlay package doesn't get overlaid accordingly either. (sidenote: This RRO file being on /vendor, whereas opengapps supposedly lives completely on the system partition is the reason GoogleWebViewOverlay exists and is placed on /system or /product). If anyone feels like debugging, be my guest. For now this change is reverted to the old behaviour on SDK 24-28. Fixes: 95a9e11 Signed-off-by: MarijnS95 <marijns95@gmail.com>
- Loading branch information