Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy logs to sdcard/ when using sideload #794

Merged
merged 1 commit into from Jan 21, 2020
Merged

Copy logs to sdcard/ when using sideload #794

merged 1 commit into from Jan 21, 2020

Conversation

ipdev99
Copy link
Contributor

@ipdev99 ipdev99 commented Jan 16, 2020

When using adb sideload, log files are not saved.
(/sideload is RO)

If you use a gapps-config file, the logs will be saved in the same directory as the config file.
If you do not use a config file, then the log files are copied to /sideload and disappear.

For now, copying the logs to /sdcard when /sideload is detected seems to work.

Copy link
Contributor

@nezorflame nezorflame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfonville
Copy link
Member

Thanks!

@mfonville mfonville merged commit 8a4de77 into opengapps:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants