installer: mount /product for non dynamic devices as well

[merothh]

• As we dont mount /product for devices that are not dynamic
  and have a separate partition, on such devices AOSP counterpart
  apps in /product end up not being removed, among possibly other
  similar issues as well.

• So mount it.

  Thanks to @nikhilmenghani for the tip

[merothh]

(Just so that we're clear)

Verified on:

• Redmi Note 7 Pro (A only - Non Dynamic, but uses a separate product partition in custom ROMs, works fine with this patch)
• Poco X2 (A only - Dynamic, uses a separate product partition, works fine as previously)

[merothh]

Hold, while I do a follow up change for addon.d

[nezorflame]

Hi, thanks for your PR!
@osm0sis can you take a look as well?

[osm0sis]

Makes sense, I guess!

[mfonville]

So I wait for a merge until addon.d is also updated?

[osm0sis]

addon.d will be tricky, I'm not even sure if/how we handle /vendor there currently

[merothh]

So I wait for a merge until addon.d is also updated?

Yes, that would be ideal.

addon.d will be tricky, I'm not even sure if/how we handle /vendor there currently

Indeed. I didnt see anything to handle /vendor.

merothh@afa50fa

This was what i came up with then, it was working on non dynamic. But the dynamic one was screwing up and aborting the install when i dirty flashed. Not sure why, right now.

If we do manage to get it working somehow, might as well extend to it mount vendor as well (if needed).

[osm0sis]

So probably better to just merge this and have addon.d on a to-do list for later.. I'm thinking if we can get things mounted right then removals should be able to happen via the normal addon.d functions since it's all symlinked into /system.

But on dynamic, most importantly on A/B devices with addon.d-v2, those extra mounts will need to be into /postinstall, and are not standard to do, so it'll be pretty tricky.

[merothh]

So probably better to just merge this and have addon.d on a to-do list for later.. I'm thinking if we can get things mounted right then removals should be able to happen via the normal addon.d functions since it's all symlinked into /system.

But on dynamic, most importantly on A/B devices with addon.d-v2, those extra mounts will need to be into /postinstall, and are not standard to do, so it'll be pretty tricky.

Alright then. Guess it makes sense to merge this.

[mfonville]

Alright, thanks!

[nezorflame]

Let's track the addon.d issue here