Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for editing an empty vector dataset interactively #353

Merged
merged 1 commit into from Jan 31, 2023

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented Jan 31, 2023

import os
import leafmap
os.environ['MAX_PROPS'] = '20'
m = leafmap.Map()
m

Peek 2023-01-31 13-44

@giswqs giswqs linked an issue Jan 31, 2023 that may be closed by this pull request
@giswqs giswqs merged commit f405b60 into master Jan 31, 2023
@giswqs giswqs deleted the vector-edit branch January 31, 2023 18:53
@PennyJClarke
Copy link

@giswqs Thank you for the video above and updating Leafmap.

I have since updated my Leafmap version, and retried adding a shapefile, using the same method as the video above, however, the preset column heading are still not populating?

Here is a test shapefile made and exported from QGIS containing three column headings:
image

Here is the video of adding the same exported shapefile to Leafmap and no Keys automatically populate?

Media1.mp4

I am using Leafmap 0.10.5 and ipyleaflet 0.17.0 as I needed to downgrad ipyleaflet for use of the measure tool.

Thank you for your support and guidance.

@giswqs
Copy link
Member Author

giswqs commented Feb 6, 2023

You need leafmap v.0.16.0 for this feature.

@PennyJClarke
Copy link

Thank you.

I used conda install -c conda-forge leafmap and conda install leafmap=0.16.0, using both only offers Leafmap 0.15.0:
image
I removed Leafmap before reinstalling and also tried updating the package, and in both cases 0.15.0 was the newest version offered?

@giswqs
Copy link
Member Author

giswqs commented Feb 6, 2023

Create a fresh conda env to install leafmap. There might be some Python packages in your existing env that prevent leafmap from being installed.

@giswqs
Copy link
Member Author

giswqs commented Feb 6, 2023

Try out Google Colab https://colab.research.google.com/notebooks/empty.ipynb

@PennyJClarke
Copy link

@giswqs thank you for all your support to add this new feature, it is great! I successfully downloaded the new version of Leafmap and the feature works. I see by amending os.environ['MAX_PROPS'] = '20' I can increase the number of rows in the grid, however, beyond 21 I cannot see any additional rows on the screen, even in full screen view. Is it possible to scroll the rows or add a scroll feature to the attribute table? Thank you for your time.

sthagen pushed a commit to sthagen/giswqs-leafmap that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draw_control: annotation tools
2 participants