Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers as xarray.DataArray in split_map (ipyleaflet Map) #681

Merged
merged 11 commits into from Feb 14, 2024

Conversation

lopezvoliver
Copy link
Collaborator

Following #680, here's a PR that implements the ability to pass left_layer and right_layer as xarray.DataArray in split_map, here only for the ipyleaflet.Map version for now.

@giswqs
Copy link
Member

giswqs commented Feb 13, 2024

Can you also overrite the 49_split_control.ipynb under docs/notebooks, which is used for building the docs website? For now, leafmap has duplicate copies of notebooks under examples and docs. I should probably get rid of the examples folder entirely in the future.

@giswqs
Copy link
Member

giswqs commented Feb 13, 2024

The docs-build failed because the notebooks are executed with the folium backend. Would you be able to make similar changes to the split map function in foliumap.py?

@lopezvoliver
Copy link
Collaborator Author

Not sure why the docs-build test failed on notebook 83_vector_viz.ipynb

@giswqs
Copy link
Member

giswqs commented Feb 14, 2024

The notebook issue seems caused by the recent updates of the lonboard package. I have reported it at developmentseed/lonboard#365. Ignoring this notebook for now.

@giswqs giswqs merged commit 6370630 into opengeos:master Feb 14, 2024
12 checks passed
@lopezvoliver lopezvoliver deleted the split_xr branch February 26, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants