Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that version of test suite and basic conformance classes are displayed in HTML report and refactorings #25

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

dstenger
Copy link
Collaborator

@dstenger dstenger commented Nov 24, 2023

This pull request fixes that the version of test suite and basic conformance classes are displayed in HTML report.

The reason for the bug was that the resources plugin was not configured in pom.xml correctly.
@jiann Can you recall why you changed that configuration?
I created a folder resources-filtered containing all resources which shall be filtered. By that, it is prevented that files which must not be filtered are accidentally filtered. This makes the complete filtering process more robust.

Also, some refactoring was done.

@ghobona @jiann If you can review this pull request as soon as possible, I propose that it will be part of release 0.1 as well.

@dstenger dstenger added the bug Something isn't working label Nov 24, 2023
@dstenger dstenger added this to To do in CITE via automation Nov 24, 2023
@dstenger dstenger moved this from To do to To verify in CITE Nov 24, 2023
@dstenger dstenger changed the title Fix that version of test suite and basic conformance classes are not displayed in HTML report and refactorings Fix that version of test suite and basic conformance classes are displayed in HTML report and refactorings Nov 24, 2023
Copy link
Contributor

@ghobona ghobona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Screenshot 2023-11-24 at 14 29 06

@jiann
Copy link
Contributor

jiann commented Nov 27, 2023

I recall it was due to some resource being filtered, so I made a change. Although I can't recall the exact details, this commit seems to be working well and looks good!

@jiann jiann merged commit a895aea into main Nov 27, 2023
CITE automation moved this from To verify to Done Nov 27, 2023
@dstenger dstenger added this to the 0.1 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
CITE
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants