Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Issue #2

Closed
ajanett opened this issue Apr 19, 2018 · 8 comments
Closed

Dependency Issue #2

ajanett opened this issue Apr 19, 2018 · 8 comments

Comments

@ajanett
Copy link

ajanett commented Apr 19, 2018

This code has a dependency on teamengine-spi version 5.0. The build fails when building this against a later version of teamengine.

@dstenger
Copy link
Contributor

dstenger commented Apr 19, 2018

Thank you for reporting.

@keshav-nangare Can you please do further investigations?

@ajanett
Copy link
Author

ajanett commented Apr 19, 2018

I am building a configuration with TEAM Engine 5.2. The package ets-wfs20-nsg has a dependency on ets-dgiwg-core version 0.4 (and it does not build with version 0.3) The ets-dgiwg-core version 0.4 then fails to build due to a dependency on teamengine-spi version 5.0. Changing the pom to reference teamengine-spi version 5.2 fixes the problem, but I am not sure if it should have been a problem in the first place. Hence this issue report on a dependency.

@dstenger
Copy link
Contributor

I tried to build (using mvn clean install) this project with TEAM Engine 5.0 and 5.2 and it worked with both versions.

5.2 is available via Central Maven Repository and 5.0 is not available remotely (in this case, you have to build it locally first). Maybe this led to the failure of your build?

@dstenger dstenger assigned dstenger and lgoltz and unassigned keshavnangare Apr 20, 2018
@dstenger dstenger added question and removed bug labels Apr 20, 2018
@ajanett
Copy link
Author

ajanett commented Apr 20, 2018

My goal is to use TEAM Engine 5.2 and I don't believe I should have to build and install TEAM Engine 5.0 as well just to satisfy this dependency, hence this issue report. Ultimately, the question is, can the change be made to ets-dgiwg-core so that it is non-version specific with respect to TEAM Engine dependencies? Is there some critical reason that it requires TEAM Engine 5.0? I am simply looking for a clean build of the system based on a checkout of this tool at revision 0.4 with TEAM Engine 5.2 and ets-wfs20-nsg.

@dstenger
Copy link
Contributor

Short technical explanation why dependency to TEAM Engine 5.0 is existing:
TEAM Engine jar also provides interfaces which must be implemented by individual test suites (e.g. TestSuiteController). Thus, a dependency to TEAM Engine is required. As last release of ets-dgiwg-core was created quite a while ago, TEAM Engine version has not been updated yet.

However, I totally agree that this dependency should be avoided. My proposal is to extract those interfaces to a new project (e.g. teamengine-ets-api or teamengine-api) which can be used by TEAM Engine and test suites then. By this, we remove the dependency of all test suites to TEAM Engine.
I created an issue for that: opengeospatial/teamengine#335

@ajanett
Copy link
Author

ajanett commented Apr 23, 2018

Thank you for the explanation.

@dstenger
Copy link
Contributor

I propose to update dependency to TEAM Engine 5.2 and then close this issue.

@dstenger dstenger assigned keshavnangare and unassigned dstenger and lgoltz Apr 24, 2018
keshavnangare pushed a commit that referenced this issue Apr 25, 2018
@keshavnangare
Copy link
Collaborator

Fixed with this commit: 3c9d05f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants