Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure due to space in filename #64

Closed
ajanett opened this issue Jun 12, 2018 · 6 comments
Closed

Failure due to space in filename #64

ajanett opened this issue Jun 12, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@ajanett
Copy link
Contributor

ajanett commented Jun 12, 2018

The GeoPackage specification has no limitations on characters in filenames and does not state that spaces are not allowed. The only requirement is 'A GeoPackage SHALL have the file extension name ".gpkg".'. In the case that a geopackage has the .gpkg extension, but a space in the name, the ETS fails with an immediate Fatal Error in calling an extension function which eventually tells us there is an "illegal character in path'. Removal of the space from the file name corrects the issue. However, the problem here is that the test code should not HARD fail on such an item. If spaces are a problem and not to be allowed, the test code should report this as an issue; and the specification should also include the requirements to support this if necessary.

@jyutzler
Copy link
Contributor

jyutzler commented Jun 13, 2018

Now that the TC is behind me, I'm looking at a sprint on the ETS. I will take a look at this and other ETS issues.

@jyutzler
Copy link
Contributor

This must be a TEAM engine problem. PR #65 does not duplicate the issue. I am unassigning myself.

@jyutzler jyutzler removed their assignment Jun 13, 2018
@dstenger
Copy link
Contributor

@keshav-nangare Can you please do further investigation and create a TEAM Engine issue in case it is related to it?

@keshavnangare
Copy link

Fixed with this commit: 11c912d [PR: #64]

@dstenger
Copy link
Contributor

Fix did not work and merged branch was reverted: #66 (comment)

@keshavnangare
Copy link

Fixed this issue with commit: ed41f4c

Tested the fix with following data:

  1. emp ty.gpkg

  2. bluemarble.gpkg

@dstenger dstenger assigned dstenger and lgoltz and unassigned keshavnangare Jun 22, 2018
@lgoltz lgoltz added this to the 0.7 milestone Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants