No requirement can be found for test "feature S R Sconsistency"

[dstenger]

Test:

ets-gpkg12/src/main/java/org/opengis/cite/gpkg12/features/FeaturesTests.java

Lines 304 to 361 in 4770263

	/**
	* Test case
	* /base/core/contents/data/table_def/srs_id
	*
	* @see <a href="http://www.geopackage.org/spec120/index.html" target=
	* "_blank">Contents - Requirement 13</a>
	*
	* @throws SQLException
	* If an SQL query causes an error
	*/
	@Test(description = "See OGC 12-128r14: Requirement 13 srs_id")
	public void featureSRSconsistency() throws SQLException {
	// This requirement is not currently called out under the TEST req area,
	// but it is defined within Requirement 13 and not currently tested under
	// the requirement 13 test code.
	//
	// Spatial Reference System ID:
	// gpkg_spatial_ref_sys.srs_id; when data_type is features, SHALL also match
	// gpkg_geometry_columns.srs_id;
	int gpkgGeomCount = 0;
	int gpkgContentCount = 0;
	int gpkgAndContentCount = 0;
	try (
	final Statement statement2 = this.databaseConnection.createStatement();
	final ResultSet resultSet2 = statement2.executeQuery(
	String.format("SELECT count(*) as ggcCount FROM \'gpkg_geometry_columns\';"));
	) {
	gpkgGeomCount = resultSet2.getInt("ggcCount");
	}
	try (
	final Statement statement2 = this.databaseConnection.createStatement();
	final ResultSet resultSet2 = statement2.executeQuery(
	String.format("SELECT count(*) as ggcCount FROM \'gpkg_contents\' WHERE data_type = \'features\';"));
	) {
	gpkgContentCount = resultSet2.getInt("ggcCount");
	}
	try (
	final Statement statement2 = this.databaseConnection.createStatement();
	final ResultSet resultSet2 = statement2.executeQuery(
	String.format(
	"SELECT count(*) as ggcCount FROM \'gpkg_contents\' INNER JOIN \'gpkg_geometry_columns\' ON ((gpkg_contents.srs_id = gpkg_geometry_columns.srs_id) AND (gpkg_contents.table_name = gpkg_geometry_columns.table_name));"));
	) {
	gpkgAndContentCount = resultSet2.getInt("ggcCount");
	}
	// If the geopackage geometry columns count is not the same as the geopackage content count (for features), then we have a problem.
	if (gpkgGeomCount != gpkgContentCount) {
	Assert.assertTrue(false,
	ErrorMessage.format(ErrorMessageKeys.FEATURE_GEOMETRY_COLUMNS_DOES_NOT_MATCH_CONTENTS_COUNT));
	// If we got a different count when looking at common feature names and srs_id values, then the test for requirement 13 fails
	} else if (gpkgGeomCount != gpkgAndContentCount || gpkgContentCount != gpkgAndContentCount) {
	Assert.assertTrue(false,
	ErrorMessage.format(ErrorMessageKeys.FEATURE_GEOMETRY_COLUMNS_SRS_ID_NOT_CONSISTENT_WITH_CONTENTS));
	}
	}

Test fails because the results of two sql statements are not equal (first if):

• SELECT count(*) as ggcCount FROM 'gpkg_geometry_columns';
  • returns 68
• SELECT count(*) as ggcCount FROM 'gpkg_contents' WHERE data_type = 'features';
  • returns 34

The test expects that both counts are equal.

In http://www.geopackage.org/spec/ I cannot find a test case with id /base/core/contents/data/table_def/srs_id, and I don't see that Requirement 13 makes the test necessary.
Furthermore the if-else-statement in the end of the test can be simplified.

[jyutzler]

What is the test file that reproduces the false-positive?
BTW, this test was added as part of acbf3c5#diff-cd87833e776c4a923a7e470580031367

[ajanett]

Since this test is not in the current spec, it is only implied by requirement 13; and due to the fact that the test is being added to the upcoming specification, I recommend that this version of the test be removed at this time until it can be added for the upcoming specification.

[lgoltz]

@ajanett, @jyutzler
Shall we remove the test completely or implement Requirement 13 as it is specified in 1.2?

[jyutzler]

@lgoltz I do not feel comfortable answering this question until I can see a proper test case. Without it, I can't envision how we can go wrong.

[lgoltz]

@jyutzler The test fails with https://hawk.compusult.net/ogc/PR_GGDM_3.0_Profile_File_Geodatabase.gpkg

[ajanett]

The issue is that since srs_id is held in both gpkg_contents and gpkg_geometry_columns, it is possible for data integrity issues to occur.

The test is to ensure that for each table_name within gpkg_contents, verify that srs_id is consistent between gpkg_contents and gpkg_geometry_columns.

A better SQL for this test for the FEATURES is:
SELECT gpkg_geometry_columns.table_name, gpkg_geometry_columns.srs_id FROM gpkg_geometry_columns INNER JOIN gpkg_contents ON (gpkg_geometry_columns.table_name = gpkg_contents.table_name) WHERE (gpkg_contents.data_type = 'features' and gpkg_contents.srs_id != gpkg_geometry_columns.srs_id);
Fail if the SQL returns any rows

[ajanett]

Requirement 146 was added to the specification to specifically address this issue and I believe that requirement is also coded into the ets-gpkg20. Therefore the FeatureSRSConsistency method may be removed and this issue can be closed.

[jyutzler]

My assessment is that the check comparing the row counts of gpkg_data_columns to row counts of gpkg_contents where datatype="features" is invalid because there may be extensions that use gpkg_data_columns with a different datatype.

This test file is a bit big to add to the ETS so I will reproduce the issue elsewhere.

Since there is already a test for R146 at FeaturesTests.featureGeometryColumnsDataValuesSrsId(), I see no need for the existing FeaturesTests.featureSRSconsistency().

[keshavnangare]

@dstenger

We are fine with the solution and changes are successfully tested on the local environment.