Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test ConformanceTest #113

Merged
merged 1 commit into from Sep 2, 2020
Merged

Fix test ConformanceTest #113

merged 1 commit into from Sep 2, 2020

Conversation

heidivanparys
Copy link
Contributor

Fix test ConformanceTest by making it a JUnit test and updating the URIs
of the requirements classes.

@heidivanparys
Fix test ConformanceTest
abc4d3e 
Fix test ConformanceTest by making it a JUnit test and updating the URIs
of the requirements classes.
@heidivanparys
Copy link
Contributor Author

See also the first screenshot in #112 : test testParseAndValidateRequirementClasses fails.

@heidivanparys heidivanparys mentioned this pull request Jul 6, 2020
Closed
@ghobona
Copy link
Contributor

ghobona commented Jul 6, 2020

@heidivanparys There are two types of tests in the ETS.

Compliance tests: These are the executable tests that are implemented according to the specification of the abstract tests in the OGC standard. They are implemented using TestNG in this Executable Test Suite.

Unit tests: These are integration tests that check whether the Compliance Tests are behaving as expected. Unit tests are implemented using junit.

The two types of tests are not interchangeable.

@ghobona
Copy link
Contributor

ghobona commented Jul 6, 2020

@dstenger Please note that the edits to conformance/req-classes.json appear correct.

@ghobona ghobona requested a review from dstenger July 6, 2020 18:10
@ghobona ghobona added this to To do in CITE via automation Jul 6, 2020
@ghobona
Copy link
Contributor

ghobona commented Jul 8, 2020

@keshav-nangare Please review the PR as discussed today 2020-07-08

Conformance section in the spec is http://docs.opengeospatial.org/is/17-069r3/17-069r3.html#_response_3

@keshavnangare keshavnangare moved this from To do to In progress in CITE Jul 13, 2020
@keshavnangare
Copy link

@ghobona @dstenger

I have tested this PR successfully.

@keshavnangare keshavnangare moved this from In progress to To verify in CITE Jul 15, 2020
@dstenger dstenger assigned dstenger and lgoltz and unassigned keshavnangare Jul 22, 2020
@dstenger dstenger merged commit f470d00 into opengeospatial:master Sep 2, 2020
CITE automation moved this from To verify to Done Sep 2, 2020
@dstenger dstenger added this to the 1.1 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstenger dstenger Awaiting requested review from dstenger

@keshavnangare keshavnangare Awaiting requested review from keshavnangare

Assignees

@dstenger dstenger

@lgoltz lgoltz

Labels
None yet
Projects
CITE
  
Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@heidivanparys @ghobona @keshavnangare @dstenger @lgoltz