Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCoverage_TemporalSubset_TimePeriod_With_Resolution has problem #72

Closed
greatzzk opened this issue Jun 10, 2022 · 10 comments · Fixed by #73
Closed

GetCoverage_TemporalSubset_TimePeriod_With_Resolution has problem #72

greatzzk opened this issue Jun 10, 2022 · 10 comments · Fixed by #73
Assignees
Labels
Projects
Milestone

Comments

@greatzzk
Copy link

The test is to verify that when a GetCoverage request with a TimePeriod with resolution is submitted, the response is not an exception.

In my test, after describe coverage, it is making get coverage with the following request:
http://myserver:6080/arcgis/services/mynetcdf_111/ImageServer/WCSServer?&request=GetCoverage&identifier=mynetcdf&Format=image/GeoTIFF&service=WCS&BoundingBox=0,0,400,611,urn:ogc:def:crs:OGC::imageCRS&TimeSequence=2013-1-17T00:00:00Z/2013-5-17T00:00:00Z/P1D&version=1.1.1

The problem is at Time Sequence parameter. The parameter the test sends doesn't follow iso8601 time spec.
Instead of using 2013-1-17T00:00:00Z/2013-5-17T00:00:00Z/P1D, it should be using 2013-01-17T00:00:00Z/2013-05-17T00:00:00Z/P1D

@dstenger dstenger added this to To do in CITE via automation Jun 10, 2022
@dstenger dstenger self-assigned this Jun 10, 2022
@dstenger
Copy link
Contributor

Thank you for reporting.

I agree with your conclusion that the time format should be as defined in specification OGC 07-067r2:

9.3.2.4 Summary of ISO 8601 syntax for time positions and time periods
The [ISO 8601:2000] syntax for dates and times may be summarized by the following
template (see Annex D of the OGC Web Map Service [OGC 06-042]):
ccyy-mm-ddThh:mm:ss.sssZ
...
The WCS GetCoverage KVP syntax (defined in 10.2.2) extends ISO 8601:2000 with a
syntax for time lists and ranges, as specified in Annex D of [OGC 06-042]. Some examples
follow:
EXAMPLE 7 2000-06-23T20:07:48.11Z (A single moment)
EXAMPLE 8 1999-01-01,1999-04-01,1999-07-01,1999-10-01 (A list of four dates)
EXAMPLE 9 1995-04-22T12:00Z/2000-06-21T12:00Z/P1D
(Daily (“P1D”) between 12 noon on April 22 1995 and 12 noon on June 21, 2000)

However, the test retrieves the value of TimeSequence from a DescribeCoverage request.

Code:

<xsl:variable name="TimePosition"><xsl:value-of select = "$describe-min-result/*[local-name()='CoverageDescriptions']/*[local-name()='CoverageDescription']/*[local-name()='Domain']/*[local-name()='TemporalDomain']/*[local-name()='TimePeriod']/*[local-name()='BeginPosition']"/></xsl:variable>

<ctl:param name="TimeSequence"><xsl:value-of select="concat(substring($TimePosition, 1, 5), max((number(substring($TimePosition, 6, 2)) - 2, 1)), substring($TimePosition, 8))"/><xsl:value-of select="'/'"/><xsl:value-of select="concat(substring($TimePosition, 1, 5), min((number(substring($TimePosition, 6, 2)) + 2, 12)), substring($TimePosition, 8))"/>/P1D</ctl:param>

@greatzzk Unfortunately, I cannot access your test service but I assume that it returns an invalid time format in element BeginPosition (please check XPath in referenced code) when requested via DescribeCoverage.
Can you please check this?

@dstenger dstenger moved this from To do to In progress in CITE Jun 10, 2022
@greatzzk
Copy link
Author

@dstenger thank you!
I will send you an email for accessing the testing service, but i hope the screenshot at the bottom explains it, in which describe coverage results have correct time format.
By looking at your code, it looks like it involves some numeric calculations, That part is very suspicious that could have trimmed the "0" in front of a month numer
image

@dstenger dstenger assigned bpross-52n and unassigned dstenger and greatzzk Jun 20, 2022
@dstenger dstenger moved this from In progress to To do in CITE Jun 20, 2022
@dstenger dstenger added the bug label Jul 11, 2022
@dstenger dstenger moved this from To do to Waiting in CITE Aug 4, 2022
@ghobona
Copy link
Contributor

ghobona commented Oct 13, 2022

@greatzzk Is this issue still occurring?

@dstenger dstenger moved this from Waiting to To do in CITE Oct 13, 2022
@greatzzk
Copy link
Author

@ghobona yes it is still occurring
http://3.87.88.176:6080/arcgis/services/mynetcdf_111/ImageServer/WCSServer?request=GetCapabilities&service=WCS
pls run this service again te2 to reproduce

@greatzzk
Copy link
Author

@ghobona are you able to reproduce the problem with my service?

@dstenger dstenger assigned dstenger and unassigned bpross-52n Oct 18, 2022
@dstenger
Copy link
Contributor

@greatzzk Thank you for providing the endpoint. Yes, we are able to reproduce the problem.

@dstenger
Copy link
Contributor

A pull request solving the problem was created: #73

@dstenger dstenger moved this from To do to To verify in CITE Oct 18, 2022
@dstenger dstenger assigned bpross-52n and unassigned dstenger Oct 18, 2022
@dstenger dstenger added this to the 1.16 milestone Oct 18, 2022
@greatzzk
Copy link
Author

thanks. let me know when the issue is verified on te2 so that i can turn off the aws instance.

@greatzzk
Copy link
Author

can this be deployed to te2 so that i can verify the issue?

@dstenger
Copy link
Contributor

@greatzzk We will create a new Beta release within coming week (by October 31). An announcement will be sent to the cite-forum mailing list.

CITE automation moved this from To verify to Done Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CITE
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants