Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in "describe Unknown Feature Type" test #144

Closed
clausnagel opened this issue Mar 20, 2019 · 4 comments · Fixed by #150
Closed

Error in "describe Unknown Feature Type" test #144

clausnagel opened this issue Mar 20, 2019 · 4 comments · Fixed by #150
Assignees
Labels
Projects
Milestone

Comments

@clausnagel
Copy link
Member

The "describe Unknown Feature Type" test uses the following query to provide an unknown feature type for the DescribeFeatureType operation. It expects the WFS to respond with a HTTP status code 400.

?service=WFS&version=2.0.0&request=DescribeFeatureType&typenames=ns90:Unknown1.Type&namespaces=xmlns(xml,http://www.w3.org/XML/1998/namespace),xmlns(ns90,http://example.org),xmlns(wfs,http://www.opengis.net/wfs/2.0)

However, the query uses the typenames parameter which is not defined by the WFS specification. The parameter is called typename (without the trailing 's').

So, in my opinion, the WFS should ignore the unknown typenames parameter. And since the correct typename parameter is omitted, the complete application schema shall be returned (cf. chapter 9.2.4.1). And consequently, a HTTP status code of 200 must be send.

A correct WFS implementation will therefore fail this test.

@clausnagel
Copy link
Member Author

Well, there is also another issue with this test IMHO.

The POST version runs fine because it uses the correct <wfs:TypeName> element. However, the test method describeUnknownFeatureType in the class DescribeFeatureTypeTests then checks for an InvalidParameterValue exception code. As references, cl. 8.3.4, 9.2.4.1 are listed on the method.

However, from these clauses I cannot read that an unknown feature type on a DescribeFeatureType operation shall raise an InvalidParameterValue. There is a similar requirement stated in ATS A.2.22.1.1 but this only refers to adhoc query expressions, not to DescribeFeatureType.

@lgoltz lgoltz added the bug label Apr 8, 2019
@lgoltz
Copy link
Contributor

lgoltz commented Apr 8, 2019

@clausnagel Thanks for reporting this.

typenames Parameter should be renamed to typename for DescribeFeatureType requests (I assume this also applies to other tests).

Specification/Test must be rechecked if InvalidParameterValue is the expected exception.

@lgoltz
Copy link
Contributor

lgoltz commented Apr 16, 2019

Fix is solved by PR #150.

For the question in #144 (comment) a new issue was created: #149

@dstenger dstenger moved this from To do to To verify in CITE Apr 17, 2019
CITE automation moved this from To verify to Done Apr 17, 2019
@dstenger
Copy link
Contributor

Fix was successfully tested with service provided by @clausnagel.
Test describe Unknown Feature Type is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CITE
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants