BBOXTests#invalidGeometryOperand expects exception

[lgoltz]

The test org.opengis.cite.iso19142.basic.filter.spatial.BBOXTests#invalidGeometryOperand expects an exception with InvalidParameterValue code and status code 400.

Test:

ets-wfs20/src/main/java/org/opengis/cite/iso19142/basic/filter/spatial/BBOXTests.java

Lines 197 to 224 in 35d1d4a

	/**
	* [{@code Test}] Submits a GetFeature request where the BBOX predicate
	* refers to a feature property (gml:description) that is not
	* geometry-valued. An exception is expected in response with status code
	* 400 and exception code {@code InvalidParameterValue}.
	*
	* @param featureType
	* A QName representing the qualified name of a feature type for
	* which instances exist.
	*
	* @see "ISO 19142:2010, 11.4: GetFeature - Exceptions"
	* @see "ISO 19143:2010, 8.3: Exceptions"
	*/
	@Test(description = "See ISO 19142: 11.4; ISO 19143: 8.3", dataProvider = "instantiated-feature-types")
	public void invalidGeometryOperand(QName featureType) {
	XSElementDeclaration gmlDesc = this.model.getElementDeclaration("description", Namespaces.GML);
	Element valueRef = WFSMessage.createValueReference(gmlDesc);
	WFSMessage.appendSimpleQuery(this.reqEntity, featureType);
	Envelope spatialExtent = featureInfo.get(featureType).getSpatialExtent();
	Document gmlEnv = envelopeAsGML(spatialExtent);
	addBBOXPredicate(this.reqEntity, gmlEnv.getDocumentElement(), valueRef);
	ClientResponse rsp = wfsClient.submitRequest(reqEntity, ProtocolBinding.ANY);
	this.rspEntity = rsp.getEntity(Document.class);
	Assert.assertEquals(rsp.getStatus(), ClientResponse.Status.BAD_REQUEST.getStatusCode(),
	ErrorMessage.get(ErrorMessageKeys.UNEXPECTED_STATUS));
	String xpath = "//ows:Exception[@exceptionCode='InvalidParameterValue']";
	ETSAssert.assertXPath(xpath, this.rspEntity, null);
	}

Some services returns an empty FeatureCollection.

Specification should be rechecked.

[lgoltz]

I cannot find any hint in the specification about the correct behavior.

• ATS: A.2.22.1.5.2 Invalid property name: "Test Method: Execute a query with an non-existent property name in the projection clause of a query and verify that the server generates an InvalidParameterValue exception."
• referenced Chapter 11.4: GetFeature - Exceptions does not mention the InvalidParameterValue exception
• referenced Chapter 8.3: Exceptions does not exist

I think the test should be removed.

[dstenger]

I agree regarding referenced chapter 11.4: GetFeature - Exceptions.

However, regarding Chapter 8.3 OWS Common (OGC 06-121r3) is referenced. Thus, the chapter exists.
The chapter says following:

exceptionCode value: InvalidParameterValue
Meaning of code: Operation request contains an invalid parameter value
“locator” value: Name of parameter with invalid value

Nevertheless, in my opinion the link to A.2.22.1.5.2 is not very clear.

[dstenger]

@ghobona What do you think of this issue? Shall the test be removed?

[ghobona]

We should keep the test.

The standard is clear about the exception to be returned and the response code. Please see Section 7.5, 11.4 and the attached screenshot from Section D.3.

[dstenger]

Still, it is not clear for me whether this case (see description of issue) should lead to an exception (status code 400) or to an empty feature collection (status code 200).

The specification does not clearly define this special case.

The only abstract test coming close to this test was already referenced in #147 (comment). However, it does not clarify the described case.

[ghobona]

@cportele May we please have the SWG's view on this issue?

[cportele]

It is a general issue with WFS/FES that the requirements are sometimes not clear. But let's have a look at this case:

The test in the original comment references "ISO 19142:2010, 11.4: GetFeature - Exceptions" and "ISO 19143:2010, 8.3: Exceptions".

• The tests should not reference the ISO standards, which are outdated (2.0.0 instead of 2.0.2).
• Section 8.3 in FES is about exceptions for sorting, so it does not seem applicable.
• Get Feature - Exceptions is section 11.3 in WFS. Based on the current text I would have excepted an OperationProcessingFailed exception, if there is an exception.
• With respect to the question whether an exception or an empty feature collection should be returned, my reading of FES is that it should be an exception. A spatial operator as specified by FES (and ISO 19125-1) expects two geometries as operands. If the property is not a geometry (or NULL) then this is invalid input for the operator. The same applies, if a literal is not a geometry literal.

We can discuss this in the SWG meeting today.

cc @pvretano

[ghobona]

@cportele Any further information from the SWG meeting?

[cportele]

We discussed it briefly. @pvretano agreed with my general interpretation and we decided that he will add another comment to this issue.

[pvretano]

@ghobona at its core the test is checking for an invalid Geometry operand and so if the operand does not resolve to a valid geometry (i.e. a property with a geometric value or a geometry literal) then an exception should be thrown as specified in the spec. So, @cportele's explanation is correct.

[dstenger]

Thank you for your expertise.

@ghobona Thus, I propose to leave the test as it is and to also allow OperationProcessingFailed (Status Code 403) as valid exception type.

[ghobona]

@dstenger Agreed.