New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test intersectsCurve fails with Predicate Intersects not satisfied by arguments #191
Comments
Thank you for reporting. @keshav-nangare Can you please try to reproduce the reported behavior on the master branch of the WFS 2.0 test suite? |
The test sends the following request:
Response: Response.txt The geometry with The failure message is reported when the intersect condition fails. Please check the below code for more reference: ets-wfs20/src/main/java/org/opengis/cite/iso19142/basic/filter/spatial/IntersectsTests.java Lines 220 to 224 in 464a875
|
2021-02-11 I was able to verify visually, using QGIS, that the geometries causing the error do not intersect with the linestring provided in the GetFeature request. Methodology:
So we can conclude that the Test Suite is correct in its assessment that "Predicate Intersects not satisfied by arguments." The GML files are attached, in Archive.zip |
Dear @ghobona, Thank you very much for your analysis. Why does your schema for the example files reference http://schemas.opengis.net/gml/2.1.2/feature.xsd? Do you think it would be helpful to create sample files of gml:MultiSurfaces? |
I wanted to visualise the features on QGIS, so I first created a GML file using QGIS. Changing the geometry type would not fix the issue. @dstenger and I discussed the issue this morning and determined that the LineString used to test intersection is being generated from the extent bounding corners of the complete Feature Collection. This creates a problem because not all features in the collection intersect the diagonal line from one bottom corner to one upper corner. So we have concluded that this is a bug in the test suite and can be fixed by generating the LineString from the extent bounding corners of a single feature. |
As per the comment, the generation of LineString will be using one of the geometry from the feature. So updating the method |
Updated the JUnit test which is failing when single geometry is used to calculate envelope. Please find the changes and points in comment of #192 PR. |
I have updated the Please find the current changes in #192 PR. I am not able to test changes with the provided service in issue. |
When I try to test the fix, test "intersects Curve" is skipped using the service referenced in the description of this issue. @Kate-Lyndegaard Did you change the service? If that is the case, can you please provide a new test service which can be used to test the fix? |
@dstenger I did not change the service in the orginal ticket description, however I can provide you with a new test service based on the same dataset. New test service: https://test.haleconnect.de/ows/services/org.396.239874b6-e668-4e25-8425-eeed9ae37c48_wfs?SERVICE=WFS&REQUEST=GetCapabilities&VERSION=2.0.0 Thank you @keshav-nangare and @dstenger for the fix. Kind regards, |
Thank you for the new test service. @keshav-nangare Can you please test the fix? |
I tried with the new service but it is still skipping the |
@dstenger I just tested this behavior on beta and the intersectsCurve test is still skipped for the latest example @Kate-Lyndegaard provided. How is the approach for closing/testing issues in this repository? Can we expect closed issues to be implemented on beta or not? |
@JohannaOtt |
@dstenger Thanks a lot for the detailed explanation. |
Hi,
I am receiving Predicate Intersects not satisfied by arguments ... expected [true] but found [false] for a WFS service.
WFS service: https://haleconnect.com/ows/services/org.918.cc100895-4a04-4602-a94f-8b955d136893_wfs?SERVICE=WFS&REQUEST=GetCapabilities&VERSION=2.0.0
The test IntersectsTests.intersectsCurve() fails twice with the exception: Predicate Intersects not satisfied by arguments
INSPIRE Validator Test Report:
WFS_Validator_Report_Pred.zip
The saved responses available at the links in the INSPIRE validator test report display incomplete wfs:FeatureCollections, however I cannot reproduce this using the same requests.
Could you please help me determine what the issue is?
Kind regards,
Kate
The text was updated successfully, but these errors were encountered: