Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method selectRandomFeatureIdentifiers can come into an endless loop #228

Closed
dstenger opened this issue May 16, 2022 · 1 comment · Fixed by #229
Closed

Method selectRandomFeatureIdentifiers can come into an endless loop #228

dstenger opened this issue May 16, 2022 · 1 comment · Fixed by #229
Labels
bug
Projects
CITE
Milestone
1.38

Comments

@dstenger
Copy link
Contributor

The while loop in DataSampler.selectRandomFeatureIdentifiers() can come into an endless loop when the same feature ids are used multiple times in a single feature type.

Proposed solution: Test suite fails when the same feature ids are used multiple times as the GML 3.2.1 specification (OGC 07-036; 7.2.4.5) states that the id must be unique.
@dstenger dstenger added the bug label May 16, 2022
@dstenger dstenger self-assigned this May 16, 2022
@dstenger dstenger added this to To do in CITE via automation May 16, 2022
@dstenger
Copy link
Contributor Author

GML 3.2.1 specification (OGC 07-036; 7.2.4.5):

Screenshot 2022-05-11 at 09 53 45

@dstenger dstenger moved this from To do to In progress in CITE May 16, 2022
dstenger added a commit that referenced this issue May 16, 2022
@dstenger
#228 Add check for duplicate feature ids and prevent endless loop
50b58c0
@dstenger dstenger mentioned this issue May 16, 2022
Merged
@dstenger dstenger moved this from In progress to To verify in CITE May 16, 2022
@dstenger dstenger removed their assignment May 16, 2022
@dstenger dstenger added this to the 1.38 milestone May 20, 2022
CITE automation moved this from To verify to Done May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
CITE
  
Done
Milestone
1.38
Development

Successfully merging a pull request may close this issue.

Add check for duplicate feature ids and prevent endless loop opengeospatial/ets-wfs20
1 participant
@dstenger