Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop test for a WMS 1.3 raster conformance class #12

Closed
bermud opened this issue Mar 16, 2015 · 27 comments · Fixed by #102
Closed

Develop test for a WMS 1.3 raster conformance class #12

bermud opened this issue Mar 16, 2015 · 27 comments · Fixed by #102
Assignees
Projects
Milestone

Comments

@bermud
Copy link
Contributor

bermud commented Mar 16, 2015

Develop an ETS that allows to test only WMS that publishes rasters.

See related email: http://lists.opengeospatial.org/pipermail/cite-forum/2011-February/000436.html

Reason: some products specialize in raster handling and does not support vector input.

@sptillma
Copy link

Over the recent years, there has been a lot of good work improving the CITE tests. But this issue that I raised over two years ago still has not been addressed. As this capability to create a WMS over a raster image is rather basic functionality for one of our oldest standards, it seems we should create a test for this option. I would be ok if we did not attempt to change older tests and only inserted this for version 1.3. Any chance of getting this added to the roadmap?

@dstenger
Copy link
Contributor

Thank you for the input.

Can you explain the specific aim of such a test? In specification, for example, I do not see a conformance class just covering this case.

@sptillma
Copy link

I'm not sure why you are asking this question as the WMS has been supporting raster based data deliver since its beginning - this is certainly not a new concept. I am simply pointing out that the current test suite is biased toward those that stand up vector based Web Map Services - I don't see a conformance class specific to vector data either. The current data set that is used for the WMS tests is based on Shapefile. We have a product whose purpose is to deliver imagery faster than any other product and it does not include any vector capabilities. However, we cannot certify the WMS on this product because many of the tests assume the use of the vector test data. I realize a lot of the existing tests can be reused, but I would like the option of having some tests (such as the initial picture verification) that could be based on raster test data. Does this make sense what I am asking for?

@dstenger
Copy link
Contributor

So, you are asking if the WMS interface which is tested can base on raster source data.
I agree. As the current test data just contain vector data, it is not possible to test a raster based WMS interface.

Thus, the task is to create raster test data and, after that, to adjust the tests.

@sptillma
Copy link

Exactly! I'm glad to see we are now on the same page. I simply want to see the tests that are specific to the provided vector data be enhanced (or duplicated) to allow for a raster option. Other tests for things like GetCapabilities should be fine as they are for the most part.

@dstenger
Copy link
Contributor

I propose to enhance the existing test suite to allow testing of raster data sources only.

@bermud What do you think about this?

@dstenger dstenger added this to To do in CITE via automation Dec 9, 2019
@dstenger dstenger assigned ghobona and unassigned bermud Jan 7, 2020
@bangph
Copy link

bangph commented Oct 11, 2022

@dstenger @bermud yes that is great to support test suites WMS for only service providing raster. Vector is not needed here.
It has been 4 years already.

@ghobona
Copy link
Contributor

ghobona commented Oct 12, 2022

@bangph OGC are looking for volunteer developers to enhance this and other executable test suites. Let us know if you are aware of someone that might be interested in volunteering to implement the enhancement.

@bangph
Copy link

bangph commented Oct 12, 2022

@ghobona I've tried to run test WMS yesterday and basically, just disable the tests below for WMS which require vector shapefiles, so it is done. I don't know anyone who will contribute to remake the whole tests for raster conformance class, but my idea is a quick solution for that.

image

@ghobona
Copy link
Contributor

ghobona commented Oct 12, 2022

@bangph That does indeed sound like a quick solution. We could add a button to the form to disable all of the vector-related tests. We would also need to update the documentation to explain how to use the raster conformance test.

@dstenger dstenger assigned bpross-52n and unassigned dstenger, lgoltz and ghobona Oct 13, 2022
@bangph
Copy link

bangph commented Oct 17, 2022

@ghobona exactly, I hope this could be implemented soon (as it seems to be not a lot of works) in OGC CITE from your description, so others with their raster supports only could pass WMS for raster conformance tests.

@bangph
Copy link

bangph commented Oct 26, 2022

@dstenger @ghobona do you think my proposal to strip vector testings from WMS 1.3.0 OGC CITE test could be done in the next few weeks? That would help services which only support raster could be certified with WMS raster conformance.

@ghobona
Copy link
Contributor

ghobona commented Oct 31, 2022

@bangph It's on the backlog, however as of 2022-10-31 there are ten tickets ahead of it. So we might get to it in January 2023. We will try our best.

@bangph
Copy link

bangph commented Nov 1, 2022

@ghobona thanks for letting me know about the milestone. I think if something is easy like this one, it might be better to do first from the backlog to reduce it faster.

@dstenger dstenger moved this from To do to In progress in CITE Nov 24, 2022
@dstenger
Copy link
Contributor

@bangph Do you have a service which just contains raster data and we can use for testing purposes?

@bangph
Copy link

bangph commented Dec 15, 2022

@bpross-52n bpross-52n mentioned this issue Jan 12, 2023
@bpross-52n bpross-52n linked a pull request Jan 12, 2023 that will close this issue
@ghobona
Copy link
Contributor

ghobona commented Jan 12, 2023

I have taken an action to look into a possible alternative solution.

@ghobona
Copy link
Contributor

ghobona commented Jan 26, 2023

Attached are transparent PNG World Files for each layer.

We are looking into their use as a raster alternative.

cite_wms_ets_sample_world_files.zip

@ghobona
Copy link
Contributor

ghobona commented Feb 6, 2023

The approach of uploading PNG world files has been verified to work.

The files in the Comment above were uploaded into GeoServer 2.22.1 and the CRS set to reproject to EPSG:4326.

As shown on the attached screenshot the approach worked. Note that the Geoserver instance used in this demo did not have HTTPS configured, hence the need to open the images in a separate tab or window by right clicking.

We will provide the PNG world files on the next revision of the ETS as an alternative to shapefiles.

Screenshot 2023-02-06 at 11 48 09 SUCCESS

@ghobona ghobona removed their assignment Feb 6, 2023
@ghobona
Copy link
Contributor

ghobona commented Feb 6, 2023

The test results are attached.

20230206_GeoServer_TestSessionResults.pdf

@ghobona ghobona self-assigned this Feb 9, 2023
@ghobona
Copy link
Contributor

ghobona commented Feb 16, 2023

  • @ghobona To place the raster files in the ETS documentation so that they are downloadable as a separate ZIP file (i.e. not in the same ZIP file as the vector files).

@ghobona
Copy link
Contributor

ghobona commented Mar 2, 2023

ghobona added a commit that referenced this issue Mar 2, 2023
@ghobona
Copy link
Contributor

ghobona commented Mar 2, 2023

Pull Request created, and assigned to @bpross-52n .

@dstenger dstenger moved this from In progress to To verify in CITE Mar 9, 2023
@dstenger dstenger assigned dstenger and unassigned bpross-52n and ghobona Mar 9, 2023
@dstenger dstenger added this to the 1.29 milestone Mar 24, 2023
CITE automation moved this from To verify to Done Mar 24, 2023
@bangph
Copy link

bangph commented Mar 29, 2023

@dstenger There should have a checkbox to disable vector tests on https://cite.opengeospatial.org/teamengine/ for test WMS 1.3.0. If I don't click on the checkbox, so I only test raster conformance.

@dstenger
Copy link
Contributor

dstenger commented Mar 29, 2023

We decided to go with a different approach which is described in #12 (comment).
The corresponding pull request is #102.

Release 1.29 of the test suite will be created and installed on Beta environment (https://cite.ogc.org/te2/) in the coming days.

@bangph
Copy link

bangph commented Jun 27, 2023

@dstenger thank you for the information above. When is it possible to have release 1.29 to https://cite.opengeospatial.org/teamengine?

I saw it has only version 1.28 (given this ticket is closed ~3 months ago).

Web Map Service (WMS) 1.3.0 1.28 Final

@dstenger
Copy link
Contributor

dstenger commented Jul 3, 2023

We are planning an update of Production for late summer/autumn this year. Then, we are moving all tested bug fix versions from Beta to Production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CITE
  
Done
7 participants