New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between "Table 10. Tiles Table or View Definition" and C.7. sample_tile_pyramid #358

Closed
rouault opened this Issue Apr 27, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@rouault
Contributor

rouault commented Apr 27, 2017

Table 10 mentions that 0 should be used as default value for zoom_level, tile_column and tile_row, but Annex C.7 does not have "DEFAULT 0" in the DDL.

A default value for records in a tile pyramid table doesn't make sense to me, so I think the example is right.

/opt/tiles/tile_pyramid/data/table_def only tests the existence of those columns, and not their type, not null constraint or default values.

@jyutzler jyutzler added this to the 1.2-comment period milestone Apr 27, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Jun 27, 2017

In the SWG meeting yesterday, we agreed to accept this change. It will be included as part of 1.2.

jyutzler added a commit to jyutzler/geopackage that referenced this issue Jun 27, 2017

jyutzler added a commit that referenced this issue Jun 27, 2017

Merge pull request #371 from jyutzler/i358
removing improper defaults #358

@jyutzler jyutzler closed this Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment