Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarifying the use of byte order flags #559

Merged
merged 2 commits into from
Dec 22, 2020
Merged

clarifying the use of byte order flags #559

merged 2 commits into from
Dec 22, 2020

Conversation

jyutzler
Copy link
Contributor

closes #548

@jyutzler jyutzler added this to the 1.3.0 milestone Nov 21, 2020
@jyutzler jyutzler mentioned this pull request Nov 21, 2020
Closed
phidrho
phidrho reviewed Nov 21, 2020
View reviewed changes
Copy link

@phidrho phidrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I would also suggest to change row 144

from:

* B: byte order for header values (1-bit Boolean)

to:

* B: byte order for SRS_ID and envelope values in header (1-bit Boolean)

@jyutzler jyutzler merged commit 5187315 into opengeospatial:master Dec 22, 2020
@jyutzler jyutzler deleted the i548 branch December 22, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phidrho phidrho phidrho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Does byte flag in GeoPackageBinary about the endianness refer to whole header, or only to envelope?
2 participants
@jyutzler @phidrho