Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Z in the geometry type? #132

Closed
m-mohr opened this issue Oct 25, 2022 · 5 comments · Fixed by #140
Closed

Declare Z in the geometry type? #132

m-mohr opened this issue Oct 25, 2022 · 5 comments · Fixed by #140
Assignees
Milestone

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 25, 2022

    Do we need to declare `Z` in the geometry type? It might make it a little harder on the writer side

Originally posted by @kylebarron in #131 (comment)

@tschaub
Copy link
Collaborator

tschaub commented Oct 25, 2022

I'd be in favor of removing this removing this language from the spec:

In case of 3D geometries, a " Z" suffix gets added (e.g. "Point Z")

I suppose someone could check the length of the bbox if they wanted to know how many dimensions they might encounter in coordinate values.

@rouault
Copy link
Contributor

rouault commented Oct 25, 2022

`` if they wanted to know how many dimensions they might encounter in coordinate values.

if M support is added someday, checking the bbox length will not be enough to distinguish Z from M.

@tschaub
Copy link
Collaborator

tschaub commented Oct 25, 2022

@rouault - Do you think it is important to know if the geometry includes Z? Curious if there are cases where not all positions have Z (and uncertain what this would mean for parsers that use this hint).

@rouault
Copy link
Contributor

rouault commented Oct 25, 2022

Do you think it is important to know if the geometry includes Z?

With my GDAL hat on, yes. There are definitely formats to which you could convert GeoParquet that need to distinguish upfront if geometries are going to be 2D or 3D. PostGIS is a prominent one. If that's not communicated upfront, the OGR Parquet driver would need to read the first feature (and possibly more features if the first ones have NULL geometries) to be able to guess the dimension.
Mix of dimensions inside a layer is probably less common, and could be solved by declaring [ "Polygon", "PolygonZ" ] as geometry_type.

@cholmes cholmes added this to the 1.0.0-beta.1 milestone Nov 7, 2022
@cholmes
Copy link
Member

cholmes commented Nov 7, 2022

Call 117 - We need to update the schema to reflect the spec, but general consensus seems to be we should do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants