Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify null/missing crs key #225

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Clarify null/missing crs key #225

merged 1 commit into from
Jun 1, 2024

Conversation

kylebarron
Copy link
Collaborator

@kylebarron kylebarron commented May 30, 2024 •
edited

Added wording to more strongly highlight the difference in semantic meaning between a missing crs key and a crs key set to null.

jorisvandenbossche
jorisvandenbossche approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's indeed clearer!

@jorisvandenbossche jorisvandenbossche merged commit eec4cf8 into main Jun 1, 2024
2 checks passed
@jorisvandenbossche jorisvandenbossche deleted the kylebarron-patch-1 branch June 1, 2024 07:43
@kylebarron kylebarron mentioned this pull request Jun 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaub tschaub tschaub approved these changes

@cholmes cholmes cholmes approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kylebarron @tschaub @cholmes @jorisvandenbossche