-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit orientation field for polygon winding #74
Merged
Merged
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6cff65d
Explicit orientation field for polygon winding
felixpalmer bdab0d2
Remove comment on opposite ring order
felixpalmer 009138a
Remove REQUIRED on orientation
felixpalmer fc4169d
Remove mention of right-hand rule
felixpalmer d4b51e3
Explicit note on lack of consistency
felixpalmer 8d4b786
Wording update on writers
cholmes 5f85f23
Reverse crs/orientation order
felixpalmer b58c85b
Typo
felixpalmer d0387fd
Add quotes
felixpalmer 2a96085
updates to talk about spherical more, minor tweaks
cholmes 5a15787
Validator update with orientation
felixpalmer 2112a83
Update example file to include orientation
felixpalmer 48821fc
Update example_metadata.json to 0.3.0
felixpalmer 54c21ac
Allow 0.3.0 version
felixpalmer fc09267
Only allow 0.3.0
felixpalmer b9f5954
0.3.0 in spec
felixpalmer 659c1a8
Revert change of 0.3.0 to 0.2.0
felixpalmer 9fb9d0a
Don't use const
felixpalmer 87e5c2e
Metadata fix
felixpalmer 06a11cc
Note on spherical + orientation
felixpalmer f968c7d
Note on spherical + orientation
felixpalmer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, as the example data is not actually using CCW rings.
The current example file is converted from a Shapefile, which has by definition an opposite winding order.
(ideally we would have multiple examples so we have both cases covered, but until then we should ensure this is correct for the current file)