Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit orientation field for polygon winding #74
Explicit orientation field for polygon winding #74
Changes from 16 commits
6cff65d
bdab0d2
009138a
fc4169d
d4b51e3
8d4b786
5f85f23
b58c85b
d0387fd
2a96085
5a15787
2112a83
48821fc
54c21ac
fc09267
b9f5954
659c1a8
9fb9d0a
87e5c2e
06a11cc
f968c7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, as the example data is not actually using CCW rings.
The current example file is converted from a Shapefile, which has by definition an opposite winding order.
(ideally we would have multiple examples so we have both cases covered, but until then we should ensure this is correct for the current file)