Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections of example data and queries #29

Closed
lvdbrink opened this issue Oct 18, 2019 · 2 comments · Fixed by #159
Closed

Corrections of example data and queries #29

lvdbrink opened this issue Oct 18, 2019 · 2 comments · Fixed by #159
Assignees
Labels
change request documentation Improvements or additions to documentation
Milestone

Comments

@lvdbrink
Copy link
Collaborator

Official change request: OGC CR 173

Errors in example data and queries might lead to wrong implementations. In the given example data in B.1. (page 51) the LineString start with (( and ends with )), although it must be single brackets.

In the third example query in B.2 (page 52) the subject of the fifth triple pattern is a variable called ?my:D although is should be no variable (my:D).

In the fourth example query in B.2 (page 54) the URL given in the prefix definition for geof is wrong. Instead of < 0 > it must be < 1 >

@jabhay jabhay transferred this issue from opengeospatial/geosemantics-dwg Sep 21, 2020
@jabhay
Copy link
Collaborator

jabhay commented Sep 21, 2020

Created MoSCoW poll




@jabhay jabhay added 1.1 change request documentation Improvements or additions to documentation labels Oct 2, 2020
@jabhay jabhay added this to the GeoSPARQL 1.1 milestone Oct 2, 2020
@jabhay jabhay removed the 1.1 label Oct 2, 2020
@jabhay jabhay added this to To do in GeoSPARQL 1.1 Oct 29, 2020
@mathib
Copy link
Contributor

mathib commented Feb 16, 2021

I believe the transformed query of the example B.3 (p54-55) also contains an error: the final UNION (geometry-geometry) should be:

UNION
{ # geometry – geometry
?f geo:asWKT ?fSerial .
my:A geo:asWKT ?aSerial .
FILTER (geof:sfOverlaps(?fSerial, ?aSerial)) }

@jabhay jabhay assigned mperry455 and unassigned kotzino Jun 2, 2021
@mperry455 mperry455 linked a pull request Jun 15, 2021 that will close this issue
@jabhay jabhay moved this from To do to In progress in GeoSPARQL 1.1 Jun 30, 2021
@jabhay jabhay moved this from In progress to Done in GeoSPARQL 1.1 Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

5 participants