Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GeoTIFF model CRS for engineering CRS #119

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

desruisseaux
Copy link
Contributor

Pull request #117 proposes the addition of a GTModelTypeGeoKey value for geocentric CRS associated to a two-dimensional spherical coordinate system. This pull request proposes to add an engineering CRS, but also associated to a two-dimensional spherical coordinate system. The definition would be similar to #117 except for the datum:

Section to edit

User-defined Model Coordinate Reference Systems with the addition of the following sub-section:

For a user-defined engineering CRS (spherical 2D) the user is expected to provide:

  • coordinate reference system name (through the EngineeringCitationGeoKey);
  • engineering datum through the EngineeringDatumGeoKey:
    • user-defined engineering datum name and other defining information:
      • the geodetic datum name (through the EngineeringCitationGeoKey);
    • axis unit through the GeogAngularUnitsGeoKey, either:
      • angle unit code (if available through standard EPSG code), or
      • user-defined angle unit name (through the EngineeringCitationGeoKey) and scaling from SI base unit of radian (through the GeogAngularUnitSizeGeoKey).

Note: GeogAngularUnitsGeoKey is not an appropriate name. Maybe this key should be renamed only AngularUnitGeoKey. Such renaming would not be a compatibility break if the numerical value does not change.

New GeoKeys

  • EngineeringCitationGeoKey
  • EngineeringDatumGeoKey

Open questions

  • Should we support a spherical 3D case?
  • Should we support a Cartesian 3D case? That one seems hard to implement because GeoTIFF images are 2D. For the shperical case, we can said that the third-dimension (the radius) is the pixel value. For the Cartesian case there is no obvious axis to use as pixel values.

…pochGeoKey`

key name from the "GeoTIFF v1.0 key name" column to the "This document key name".
In my understanding, that key didn't existed in GeoTIFF 1.0.
… and requirement 16.5.

This is a source code formatting, with no change in text and no change in the PDF or HTML formatting.
This is a complement of pull request opengeospatial#114, which was done by an automatic tool on main paragraphs only.
The formatting in this commit was done manually in preparation for future change requests with content changes.
@desruisseaux desruisseaux marked this pull request as draft September 19, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant