Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GML media types seem to be erroneous #381

Closed
dstenger opened this issue May 6, 2020 · 1 comment · Fixed by #382
Closed

GML media types seem to be erroneous #381

dstenger opened this issue May 6, 2020 · 1 comment · Fixed by #382
Assignees
@cportele
Labels
bug
Projects
Features Part 1: Core
Milestone
Part 1, Version 1...

Comments

@dstenger
Copy link
Collaborator

dstenger commented May 6, 2020 •
edited
Loading

Requirements /req/gmlsf0/definition and /req/gmlsf2/definition state that media types application/gml+xml; version=3.2; profile=http://www.opengis.net/def/profile/ogc/2.0/gml-sf0 and application/gml+xml; version=3.2; profile=http://www.opengis.net/def/profile/ogc/2.0/gml-sf2 shall be supported.

Shouldn't the profile parameter values be put into quotation marks?

Example: application/gml+xml; version=3.2; profile="http://www.opengis.net/def/profile/ogc/2.0/gml-sf0"
@cportele cportele added this to Backlog in Features Part 1: Core via automation May 8, 2020
@cportele cportele moved this from Backlog to In Progress in Features Part 1: Core May 8, 2020
@cportele cportele added this to the Part 1, Version 1.0.1 milestone May 8, 2020
@cportele cportele added bug and removed question labels May 8, 2020
@cportele cportele self-assigned this May 8, 2020
@cportele
Copy link
Member

cportele commented May 8, 2020

Yes, that is correct. The "/" and ":" are characters that need to be in quotes according to RFC 2045. I create a fix.

cportele added a commit that referenced this issue May 8, 2020
@cportele
Parameter profile should be in quotes
2385b45 
fixes #381
@cportele cportele mentioned this issue May 8, 2020
Merged
Features Part 1: Core automation moved this from In Progress to Done May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cportele cportele

Labels
bug
Projects
Features Part 1: Core
Status: Done
Features Part 1: Core
  
Done
Milestone
Part 1, Version 1.0.1
Development

Successfully merging a pull request may close this issue.

Parameter profile should be in quotes opengeospatial/ogcapi-features
2 participants
@dstenger @cportele