Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unary minus operator missing ... #709

Closed
pvretano opened this issue Jun 20, 2022 · 1 comment · Fixed by #725
Closed

Unary minus operator missing ... #709

pvretano opened this issue Jun 20, 2022 · 1 comment · Fixed by #725

Comments

@pvretano
Copy link
Contributor

I may be missing something but I don't see the unary minus operator in the BNF. For example, how would I say -a+10? I think that the numericExpression production should be:

numericExpression = minus numericExpression 
                  | arithmeticExpression
                  | numericLiteral
                  | propertyName
                  | function;

Have not checked the JSON encoding yet but changes may be required there too.

@cportele
Copy link
Member

Meeting 2022-06-20: We will make the change in the arithmeticExpression rule.

cportele added a commit that referenced this issue Jul 4, 2022
closes #709

For discussion: I have not changed the JSON Schema, i.e. one would still have to write `{ "op": "-", "args": [ 0, { "property": "myAtt" }] }`. The alternative would be to also allow only one argument for "-", but would make the schema more complex and/or less strict in validation.
Features Part 3: Filtering / Common Query Language (CQL2) automation moved this from In review to Done Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants