support bounding boxes that span the antimeridian #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #31 Note that OpenAPI includes and links still go to the master branch, i.e. will only be updated once the changes have been merged.
rcoup
reviewed
Jan 29, 2018
core/openapi/parameters/bbox.yaml
Outdated
| * Left box edge, coordinate axis 1 | ||
| * Bottom box edge, coordinate axis 2 | ||
| * Right box edge, coordinate axis 1 | ||
| * Top box edge, coordinate axis 2 |
There was a problem hiding this comment.
I presume the coordinate axis order is CRS-dependent? So Axis 1 could either be an Easting or Northing?
In that case, maybe "Lower left corner, coordinate axis 1" & "Lower left corner, coordinate axis 2" is more accurate? (cf Upper right)
Or "SouthWest" & "NorthEast"?
There was a problem hiding this comment.
Yes, I was struggling how to best write it considering that
- the axis order of the CRS applies and
- WGS84 longitude/latitude is the only CRS that we discuss in the core.
It would be nice, if we can find a wording that is unambiguous, but not (too) confusing for developers that are not familiar with coordinate reference systems. I agree, "lower left corner"/"upper right corner" is better.
|
Agreement on 2018-02-01: Merge immediately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #31
Note that OpenAPI includes and links still go to the master branch,
i.e. will only be updated once the changes have been merged.