Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CQL2 JSON Schema and some examples #902

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Fix CQL2 JSON Schema and some examples #902

merged 4 commits into from
Mar 11, 2024

Conversation

cportele
Copy link
Member

@cportele cportele commented Mar 7, 2024 •
edited
Loading

  • Add script to validate all examples.
  • Fix CQL2 JSON schema. Closes CQL2: Validation of JSON examples fails #901.
    • Include "propertyRef" and "functionRef" definitions only once in "oneOf".
    • In "functionRef", exclude all built-in CQL2 functions.
    • GeometryCollection was not supported as a geometry.
    • Change date/timestamp formats to a pattern to avoid practical validation issues.
  • Upgrade schema to JSON Schema 2020-12.
  • Fix invalid examples.
  • Update OpenAPI 3.0 schema for CQL2 to the latest changes.

@pvretano @clausnagel - This should fix the validation issues. Could you have a look at the changes?

@cportele cportele requested a review from pvretano March 7, 2024 16:22
@cportele cportele marked this pull request as ready for review March 7, 2024 17:47
@clausnagel
Copy link
Member

I tested the changes with the json-schema-validator Java library. No more validation errors. Great job, thanks, @cportele.

@cportele
Copy link
Member Author

cportele commented Mar 7, 2024

Excellent, thanks also for the quick tests with json-schema-validator!

The SWG will discuss the PR in the upcoming meeting (next Monday).

@cportele cportele mentioned this pull request Mar 10, 2024
Closed
pvretano
pvretano approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pvretano pvretano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cportele, looks good to me.

@cportele cportele merged commit 3ab9f05 into master Mar 11, 2024
@cportele cportele deleted the issue-901 branch March 11, 2024 14:18
@cportele cportele mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvretano pvretano pvretano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CQL2: Validation of JSON examples fails
3 participants
@cportele @clausnagel @pvretano