Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSuite version on API #447

Closed
carlospzurita opened this issue Dec 1, 2020 · 10 comments · Fixed by #434
Closed

TestSuite version on API #447

carlospzurita opened this issue Dec 1, 2020 · 10 comments · Fixed by #434
Assignees
Projects
Milestone

Comments

@carlospzurita
Copy link

carlospzurita commented Dec 1, 2020

As part of the ETF testing framework, that we are using in the INSPIRE Reference Validator, a dependency on the TEAM engine WFS 2.0 TestSuite is used on its own Download Service ExecutableTestSuite. This dependency is managed using the endpoint https://cite.opengeospatial.org/teamengine/rest/suites, and the ETS is assigned the version of the current TestSuite.

We were previously able to obtain the version number directly from the URL of the TestSuite (for example https://cite.opengeospatial.org/teamengine/rest/suites/wfs20/1.34/run). But now the version is gone from this endpoint, and we encountered some errors in the initialization of the TestDriver for this ETS.

What is the easiest way to get the version number for the TestSuite now, using only the REST API?

@dstenger dstenger added this to To do in CITE via automation Dec 2, 2020
@dstenger dstenger self-assigned this Dec 2, 2020
@dstenger dstenger moved this from To do to In progress in CITE Dec 2, 2020
@dstenger
Copy link
Contributor

dstenger commented Dec 2, 2020

The easiest way to get the version number of the test suites is to check following site: https://cite.opengeospatial.org/teamengine/

However, we could think of providing the version numbers of the test suites via the REST interface itself. Would that help you?

CC @ghobona

@carlospzurita
Copy link
Author

We are aware of the versioning present in the landing page on https://cite.opengeospatial.org/teamengine/, and we have used it to temporarily set it as a static value on the ETF. However, it would very useful is this could be obtained directly from the REST API, to set it automatically.

@dstenger
Copy link
Contributor

dstenger commented Dec 4, 2020

I agree that it could be useful to provide this information directly via the REST API.

We will discuss this in the CITE TEAM.

@keshavnangare
Copy link
Contributor

@dstenger

I think we have covered this in the issue #397 (comment). The PR for the above issue will be used to get the Available test suites information in the XML/JSON format which contains information about the version of the test suite.

@ghobona
Copy link
Contributor

ghobona commented Dec 8, 2020

@dstenger Can we add PR #434 , which fixes Issue #397 (comment) , to the Team Engine 5.5 milestone or even a sooner milestone?

@dstenger
Copy link
Contributor

dstenger commented Dec 8, 2020

Sure, #397 was added to 5.5 milestone. This will be the next release of TEAM Engine.

@dstenger
Copy link
Contributor

dstenger commented Dec 8, 2020

@carlospzurita Does the solution of #397 cover your requirements? If that is the case, I propose to close this issue.

@dstenger dstenger moved this from In progress to To verify in CITE Dec 9, 2020
@carlospzurita
Copy link
Author

carlospzurita commented Dec 16, 2020

Dear @dstenger

Thank you for your response. I think that this change can be useful for us, we can retrieve the TestSuite info when setting up the validator.

This PR can close this issue, but we would like to be able to test it in the staging instance. Are you planning to merge the PR soon? And do you have an approximate date for the inclusion in production?

Thank you very much.

@dstenger
Copy link
Contributor

dstenger commented Jan 6, 2021

We will update TEAM Engine on Production in summer 2021.

@ghobona
Copy link
Contributor

ghobona commented Jan 13, 2021

2021-01-13 discussion

We are planning to add this to a v5.4.1 release of TEAM Engine on Beta. This will likely be in Q1 of 2021.

Cc: @dstenger

CITE automation moved this from To verify to Done Feb 12, 2021
@dstenger dstenger added this to the 5.4.1 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CITE
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants