Answer (partial) to issue 118 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d (e.g. below 200m); Change the name of the pblh filter (e.g. to pblh_inlet_diff) to clarify it and change the filter so that only data taken more than 50m below the pblh is retained; Add some tests about this.
Closed
3 tasks
alexdanjou
requested review from
brendan-m-murphy,
joe-pitt,
ag12733 and
hdelongueville
joe-pitt
requested changes
May 13, 2024
|
Yes I think Joe is right. We want the inlet to be less than PBLH -50.
…________________________________
Dr. Anita Ganesan
Associate Professor
School of Geographical Sciences
University of Bristol
Bristol, BS8 1SS, United Kingdom
Tel: +44 117 455 1545
Email: ***@***.******@***.***>
Website: http://aganesan.blogs.bris.ac.uk<http://aganesan.blogs.ilrt.org/>
From: Joe Pitt ***@***.***>
Date: Monday, 13 May 2024 at 09:55
To: openghg/openghg_inversions ***@***.***>
Cc: Anita Ganesan ***@***.***>, Review requested ***@***.***>
Subject: Re: [openghg/openghg_inversions] Answer (partial) to issue 118 (PR #119)
@joe-pitt requested changes on this pull request.
Should it not be a < sign in L412?
i for i, pblh in enumerate(pblh_da) if inlet_height > pblh - diff_threshold
It would also be good to add the new filters to the docstring (and remove the pblh entry). Otherwise I think this is good.
—
Reply to this email directly, view it on GitHub<#119 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVCIICGYLTDZI5IGKDVPBCDZCB5YZAVCNFSM6AAAAABHQ2VU3CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJSGA4TCOJTGM>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Correct the error in pblh_inlet_diff (now keep inlet_height < pblh - diff_threshold) Add docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a filter that removes data for which the pblh is below a threshod (e.g. below 200m);
Change the name of the pblh filter (e.g. to pblh_inlet_diff) to clarify it and change the filter so that only data taken more than 50m below the pblh is retained; Add some tests about this.