Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect download content #3

Closed
shenki opened this issue Jul 19, 2021 · 4 comments
Closed

Incorrect download content #3

shenki opened this issue Jul 19, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@shenki
Copy link

shenki commented Jul 19, 2021

Hello! I am using your plugin for a running community website and it's great.

We've got a setup where we have three different maps on the one page, and they display fine. However, when using the GPX download function the file contains the incorrect content. You can see here:

https://trailrunningsa.com/mt-misery-2021/#Short

Details -> Download

Is this a bug in the plugin, or are we using it incorrectly?

@morehawes morehawes added the bug Something isn't working label Jul 19, 2021
@morehawes
Copy link
Collaborator

Hi @shenki,

Thanks for reaching out. I'm glad you like the plugin, this kind of use-case was exactly what I had in mind when creating Waymark :) I have lots more features to come!

I can see this on your site too: when downloading using the Shortcode Header each file contains the "Long" Map data. So this does appear to be a bug.

I am a little pressed for time at the moment, but I will be sure to spend some time on this in the next week or two. I will let you know if I have trouble replicating this on my end.

When Exporting from the Map Details page (i.e. clicking "Details" > "More Details") things appear to be working correctly. As a temporary work-around you could hide the Export option from the Shortcode with this CSS:

.waymark-shortcode .waymark-header .waymark-meta-export_data { display: none; }

Thanks again,

Joe

@morehawes morehawes self-assigned this Jul 19, 2021
morehawes pushed a commit that referenced this issue Jul 27, 2021
The Export feature did not download the correct Map content when displaying multiple Maps using the Shortcode.
@morehawes
Copy link
Collaborator

Hi @shenki,

I have created a fix for this, available in this branch. Please feel free to download this version and let me know if the Export feature is now working as expected.

Please note you may need to clear your browser cache (of Waymark JavaScript) to see the change.

Cheers,

Joe

@morehawes
Copy link
Collaborator

This fix is included in the latest release. Marking as closed, thanks again for bringing this to my attention.

Joe

@shenki
Copy link
Author

shenki commented Aug 19, 2021

Thanks for your help @morehawes

I've updated to the new version and it's working as we would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants