Lock map rotation #5266
Merged
Lock map rotation #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lets open some space for "lock map rotation" by merging 3 rows in one.
also i must set proper icons for lock and unlock states.
Instead of using icon and toggle it we just use checkbox.
|
🎉 Ta-daaa, freshly created APKs are available for 11163de: arm64-android |
For mobile devices.
suricactus
reviewed
May 23, 2024
suricactus
reviewed
May 23, 2024
suricactus
reviewed
May 23, 2024
nirvn
reviewed
May 24, 2024
| displayToast(qsTr('Coordinates copied to clipboard')); | ||
| } | ||
| checkable: true | ||
| checked: qfieldSettings.enableMapRotation |
There was a problem hiding this comment.
The screenshot shows an alignment issue between icons and the checkbox. This should do it:
Suggested change
| checked: qfieldSettings.enableMapRotation | |
| checked: qfieldSettings.enableMapRotation | |
| indicator.height: 20 | |
| indicator.width: 20 | |
| indicator.implicitHeight: 24 | |
| indicator.implicitWidth: 24 |
There was a problem hiding this comment.
ok thank you..
result:
Mentioned in PR code review.
nirvn
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in this PR i am going to add an option that enables or disables the mapRotation, so if user don't wants rotation it wont rotate accidentally.
In first step I merged 3 rows in
canvasMenu. previously there was 3 row showing X, Y, Copy coordinates. Now we show all the info in one row.In second step I also added this option in Settings page.
Previous:
Current:
Settings: