Skip to content

Commit

Permalink
Merge pull request #267 from m-kuhn/gc-py37
Browse files Browse the repository at this point in the history
Keep references to ongoing requests
  • Loading branch information
m-kuhn committed Nov 14, 2018
2 parents e2fa273 + bef9798 commit f83ce00
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions projectgenerator/utils/qt_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,10 @@ def selectFileNameToSave(line_edit_widget, title, file_filter, parent, extension


def make_save_file_selector(widget, title=QCoreApplication.translate('projectgenerator', 'Open File'),
file_filter=QCoreApplication.translate('projectgenerator', 'Any file(*)'), parent=None, extension='', extensions=None):
return partial(selectFileNameToSave, line_edit_widget=widget, title=title, file_filter=file_filter, parent=parent, extension=extension, extensions=extensions)
file_filter=QCoreApplication.translate('projectgenerator', 'Any file(*)'), parent=None,
extension='', extensions=None):
return partial(selectFileNameToSave, line_edit_widget=widget, title=title, file_filter=file_filter, parent=parent,
extension=extension, extensions=extensions)


def selectFolder(line_edit_widget, title, parent):
Expand All @@ -88,6 +90,9 @@ def __init__(self, error_code, msg):
self.error_code = error_code


replies = list()


def download_file(url, filename, on_progress=None, on_finished=None, on_error=None, on_success=None):
"""
Will download the file from url to a local filename.
Expand Down Expand Up @@ -123,6 +128,7 @@ def finished(filename, reply, on_error, on_success, on_finished):
if on_finished:
on_finished()
reply.deleteLater()
replies.remove(reply)

if on_progress:
reply.downloadProgress.connect(on_download_progress)
Expand All @@ -131,6 +137,8 @@ def finished(filename, reply, on_error, on_success, on_finished):

reply.finished.connect(on_reply_finished)

replies.append(reply)

if not on_finished and not on_success:
loop = QEventLoop()
reply.finished.connect(loop.quit)
Expand Down

0 comments on commit f83ce00

Please sign in to comment.