Workaround vector layer type rename in QGIS 3.30 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricactus
force-pushed
the
fix_qgis_3_30_regression
branch
from
30521fd
to
c8d2f21
Compare
m-kuhn
approved these changes
May 5, 2023
Calling `QgsVectorLayer().type().name` QGIS 3.30.x returns "Vector", while previous versions return "VectorLayer" Related issue: qgis/QGIS#53023
suricactus
force-pushed
the
fix_qgis_3_30_regression
branch
from
c8d2f21
to
83fa927
Compare
|
Hm, is that worth raising in QGIS itself? Looks like a broken python API promise that shouldn't happen until QGIS 4.0. |
See
|
|
I am merging this despite the new failing tests, as they were broken a few PRs ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
QgsVectorLayer().type().nameQGIS 3.30.x returns "Vector", while previous versions return "VectorLayer"Related issue: qgis/QGIS#53023
Fixes regression introduced in #637 .