Speed up delta_apply jobs by using an indexed column for searching #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricactus
force-pushed
the
QF-2663-slow-json-query
branch
2 times, most recently
from
24ed6c6
to
28f7efb
Compare
Filtering by `content__clientId` is causing super slow query. While in pure SQL we can index on specific field in the JSON, like: ```CREATE INDEX ON core_delta(((content->>'clientId')::uuid))``` It is not so easy to run a query that uses the index in Django ORM. Alternatively, we can create index directly on the JSON value: ```CREATE INDEX ON core_delta((content->'clientId'))``` But this will make the index 5x bigger. In summary, it was chosen to add a new indexed column with the same data as in the JSON, because it's storage cheaper and faster solution.
suricactus
force-pushed
the
QF-2663-slow-json-query
branch
from
28f7efb
to
058aa66
Compare
Base automatically changed from
QF-2676-always-upload-delta-prevent-job
to
master
May 10, 2023 09:00
faebebin
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering by
content__clientIdis causing super slow query. While in pure SQL we can index on specific field in the JSON, like:CREATE INDEX ON core_delta(((content->>'clientId')::uuid))It is not so easy to run a query that uses the index in Django ORM.
Alternatively, we can create index directly on the JSON value:
CREATE INDEX ON core_delta((content->'clientId'))But this will make the index 5x bigger.
In summary, it was chosen to add a new indexed column with the same data as in the JSON, because it's storage cheaper and faster solution.
Also:
Move
before_docker_runto be before we set job status toSTARTED