Correctly calculate Job.started_at/Job.finished_at
#655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricactus
added
bug
Since before_docker_run/after_docker_run were called respenctively before/after setting the status and started_at/finished_at, it was causing timing issues in tests and not only.
suricactus
force-pushed
the
correct_job_status_on_time
branch
from
f097692
to
515f76a
Compare
|
If it's blocking - go ahead. The fix should be easy - the |
faebebin
reviewed
May 15, 2023
docker-app/worker_wrapper/wrapper.py
Outdated
Comment on lines
326
to
327
| # only successfully finished packaging jobs should update the Project.data_last_packaged_at | ||
| if self.job.status == Job.Status.FINISHED: |
There was a problem hiding this comment.
This check was never necessary, as before the job.status = Job.status.FINISHED was set right before calling after_docker_run .
faebebin
reviewed
May 15, 2023
docker-app/worker_wrapper/wrapper.py
Outdated
| for job in Job.objects.filter( | ||
| type=Job.Type.PACKAGE, | ||
| ) | ||
| .exclude(id=self.job_id) |
There was a problem hiding this comment.
Before self.job was excluded with FINISHED jobs. Now need to exclude seperately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
before_docker_run/after_docker_runwere called respenctively before/after setting the status andstarted_at/finished_at, it was causing timing issues in tests and not only.This PR is aiming at fixing this.
TODO: