Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more strict when updating jobs, set update_fields on each .save() #664

Merged
merged 1 commit into from
May 23, 2023
Merged

Be more strict when updating jobs, set update_fields on each .save() #664

merged 1 commit into from
May 23, 2023

Conversation

suricactus
Copy link
Collaborator

Pretty much the title. Django ORM otherwise saves all properties.

@suricactus suricactus added patch Requires patch version change refactor Rewrite code to achieve the goal in a better way. labels May 22, 2023
@suricactus suricactus requested a review from faebebin May 22, 2023 13:13
faebebin
faebebin approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@faebebin faebebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suricactus suricactus merged commit 650e657 into master May 23, 2023
5 of 6 checks passed
@suricactus suricactus deleted the update_fields branch May 23, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faebebin faebebin faebebin approved these changes

Assignees
No one assigned
Labels
patch Requires patch version change refactor Rewrite code to achieve the goal in a better way.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suricactus @faebebin