QF-2700 Run makemigrations --check right after building #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: QF-2700 Run migrations check in CI |
why-not-try-calmer
changed the title
why-not-try-calmer
added
the
chore
why-not-try-calmer
force-pushed
the
QF-2700_check_makemigrations
branch
from
56ab5cc
to
0a1a3a7
Compare
|
Thank you, I am not able to comment on the arm-wrestling approach, but I believe the libqfieldsync changes are not needed in here? |
By default my editor completely hide changes to submodules. I had fixed this but a fresh reset brought the defaults back. Sorry |
|
No worries, I think we should change that to a pypi package instead. |
suricactus
approved these changes
Jun 4, 2023
why-not-try-calmer
force-pushed
the
QF-2700_check_makemigrations
branch
from
b4da829
to
d463f90
Compare
why-not-try-calmer
added a commit
that referenced
this pull request
Jun 5, 2023
* Removed libqfieldsync changes * fixed by removing staticmethod * Removed libqfieldsync changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What looked like adding a single line of code turned into me arm-wrestling the Django migration writer.
The issue is basically that the migration writer doesn't know how to serialize bound functions -- functions parameterized with an implicit reference -- and that static methods seem to be considered as bound functions.
I went for the "brutal" way of solving this: i.e. extracting the static method to a top-level function. There are other ways. Please make a commit suggestion if you are not happy with the way I went for.