Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localized path regression #924

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix localized path regression #924

merged 1 commit into from
Apr 23, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Apr 4, 2024

@suricactus , am I missing something completely obvious here or are we missing a setBadLayerHandler call since v0.26.0?

@suricactus
Copy link
Collaborator

@nirvn This should be handled by eaab36f#diff-09bee065a5c7767fb1960df829f4b0d812ede9b3f9299de26321eec6b42cb514R220

I did not check why not, I will be able to do so after 15th April.

I guess with the other crash-free fixes, we can check if libqfieldsync BadLayerHandler can work as it was initially planned to:
https://github.com/opengisch/libqfieldsync/blob/master/libqfieldsync/utils/bad_layer_handler.py#L55-L69

@nirvn
Copy link
Member Author

nirvn commented Apr 4, 2024

@suricactus , that line will not attach the bad layer handler to the project though, code requires us to do it manually. That's why it's not working. I've tested it when adding a test case in libqfieldsync.

@suricactus suricactus merged commit ca4ea0c into master Apr 23, 2024
7 of 8 checks passed
@suricactus suricactus deleted the localized_fix branch April 23, 2024 07:26
suricactus added a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants