Allow development of the SDK alongside QFieldCloud #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boardend
approved these changes
May 21, 2024
| @@ -83,6 +83,8 @@ def get(self, request: Request, projectid: str) -> Response: | |||
| path = PurePath(version.key) | |||
| filename = str(path.relative_to(*path.parts[:3])) | |||
| last_modified = version.last_modified.strftime("%d.%m.%Y %H:%M:%S %Z") | |||
| # NOTE ETag is a MD5. But for the multipart uploaded files, the MD5 is computed from the concatenation of the MD5s of each uploaded part. | |||
| # TODO make sure when file metadata is in the DB, this is a real md5sum of the current file. | |||
There was a problem hiding this comment.
Do we have a task for this TODO? (And should the TODO stay in the source code?)
There was a problem hiding this comment.
I would prefer we keep the TODO and note for the future us. As for the task, check QF-2760
suricactus
commented
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.