Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First attempt to fix the select/deselect all folder in QFieldSync #599

Merged
merged 3 commits into from
Jul 15, 2024
Merged

First attempt to fix the select/deselect all folder in QFieldSync #599

merged 3 commits into from
Jul 15, 2024

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Jul 13, 2024 •
edited
Loading

This pull request fixes the issue reposted in issue #499

test-001.mp4

suricactus
suricactus approved these changes Jul 14, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing first contributions! Thank you very much, highly appreciated! Looks good to me, there is one little comment to be addressed before merging.

qfieldsync/gui/dirs_to_copy_widget.py Outdated Show resolved Hide resolved
@SeqLaz @suricactus
Update qfieldsync/gui/dirs_to_copy_widget.py
009c984 
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
@suricactus suricactus merged commit bf7e59f into master Jul 15, 2024
7 checks passed
@suricactus suricactus deleted the QF-4545-selection_deselection_all_directories_fix branch July 15, 2024 08:53
@suricactus suricactus mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

@m-kuhn m-kuhn Awaiting requested review from m-kuhn

@nirvn nirvn Awaiting requested review from nirvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeqLaz @suricactus