Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splash page design finalization 9-3-13 #82

Closed
davidmooreppf opened this issue Sep 3, 2013 · 5 comments
Closed

splash page design finalization 9-3-13 #82

davidmooreppf opened this issue Sep 3, 2013 · 5 comments
Assignees
@acacheung

Comments

@davidmooreppf
Copy link
Member

On :: http://askthem.io/splash.html#

  1. Change page title in the Chrome to :: AskThem - question-and-answer and petitions with public figures
  2. Cross Browser! Amanda, what IE testing capacity do you have? On IE 9.0.8, the gray type in the text fields is invisible & "Notify Me" button has a red outline and faint coloring.

a) All seems fine in Chrome

b) Safari seems fine, the 'email' and 'zipcode' fields are a bit off in the text fields

c) In Firefox 22, formatting bug - the text fields are on top of each other.

  1. Signups - the confirmation page is dark text on a dark background in Chrome & Safari, but not in FF::

or ::

I'll tweak that copy, but Amanda, let's see whether we can have the confirmation message display in lighter type, or in the sky, above the big background image.

  1. Speaking of big background image - are we certain that image is optimized for web? I checked on a previous version and it was a huge image file. Can we re-save that in Photoshop and display a smaller version? I can dive back into the CSS and try to find the background image (mountains etc.).
  2. Amanda, would appreciate your help with styling on the text at left - making bullets appear properly - I could play with this but not sure what's best.
  3. I need to add another name & image to the right-hand side advisory council, will do that shortly.
  4. Need to specify email confirmation of signup on splash page with @rchekaluk. Simple text email should be fine, I can write copy for each case.
@ghost ghost assigned acacheung Sep 3, 2013
@davidmooreppf davidmooreppf mentioned this issue Sep 3, 2013
Closed
@davidmooreppf
Copy link
Member Author

More slight tweaks ::

  • please make form text darker for "email" and "zipcode" - hearing it's too light. This gray is an issue around the site, we'll have to take a look at it on staging too.
  • in layout copy below-the-fold, please make text for links darker. Currently it's too light. e.g. "AskThem is supported by a generous grant from the Knight Foundation's Tech For Engagement initiative.", where Tech For Engagement is a link, please make darker.
  • Above there's a note about displaying post-signup confirmation page. Let's add-in social sharing icons there - hopefully you can grab them from production.

acacheung added a commit that referenced this issue Sep 3, 2013
@acacheung
smaller image for splash page background #82
3d64692
@acacheung acacheung reopened this Sep 3, 2013
acacheung added a commit that referenced this issue Sep 3, 2013
@acacheung
splash page updates to avatars #82
bb7bdd6
acacheung added a commit that referenced this issue Sep 4, 2013
@acacheung
ie updates to splash page #82
84753c2
acacheung added a commit that referenced this issue Sep 4, 2013
@acacheung
update splash link colors #82
b087733
@acacheung
Copy link
Member

@davidmooreppf

  • I don't think I'm seeing the same issues in Safari. Can I get a screenshot?
  • Can we go over the confirmation page changes? I'm not quite sure what is going on here. Also, where to put social icons?

All the other changes should be taken care of.

@davidmooreppf
Copy link
Member Author

Safari issue seems fine now, maybe I wasn't updated.

Yep we can go over confirmation page - right now it displays dark text on dark background :: http://cl.ly/image/1B1l3b1D0f2t

... we can move the copy to the sky and move the image down, or whatever you think, to make it legible. And place the sharing buttons below the copy "OK, we added..."

@davidmooreppf
Copy link
Member Author

Social sharing icons!

acacheung added a commit that referenced this issue Sep 5, 2013
@acacheung
add social sharing icons on to splash page #82
7fb92ac
walter added a commit that referenced this issue Sep 5, 2013
@walter
Merge branch 'master' into official_answer
e138083 
* master: (59 commits)
  reorganizing css files
  reorganize css files
  add social sharing icons on to splash page #82
  fix double ask a question button on elected official pages #87
  remove text above issue area closed #91
  updates to questions new closed #83
  Prevent email matching from showing up on login
  Preserve type setting in navigation
  Add links to person page for committee members
  Make federal legislator default for questions#new
  Disable references & use of bill questions
  Change 'overview' text to 'government'
  made logo bigger #78
  made question titles more clickable with underlines #81
  pulling out page titles #80
  Add question coordinates for questions near you
  Fix false positive due to factory
  reorganize splash styles
  new background color grayblue #78
  update splash link colors #82
  ...

Conflicts:
	app/models/question.rb
	app/views/questions/show.html.erb
@davidmooreppf
Copy link
Member Author

OK, the confirmation copy is now legible and links back to splash homepage, which is fine. Amanda I think you can close this when you're ready on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acacheung acacheung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidmooreppf @acacheung