Sharing modal worked out #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after a new question is created. Added spec to check for the presence of the modal
|
Ok, thanks for the investigation. Will take a look at what can be done later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sharing modal into the conditional tag so that it only renders after a new question is created. Added spec to check for the presence of the modal
One thing to note:
The
questions#showspecallows new user to register and sign on to a questionis still failing due to the fact that there are two, basically identical, forms on that page when it renders. As far as I could tell, there was no way to disambiguate the two so that the spec filled out and submitted the correct form. What's happening is that it fills out the top one (the one for an elected rep to fill out) and then submits the bottom one (the one for a user to fill out).Not sure how you want to handle that so, as of this pull request, that spec is still failing.