fix: clean up constants and unused imports

opengovsg · Nov 15, 2023 · 29a0aee · 29a0aee
1 parent 376808d
commit 29a0aee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/__tests__/integration/helpers/express-auth.ts b/__tests__/integration/helpers/express-auth.ts
@@ -6,6 +6,7 @@ import * as OtpUtils from 'src/app/utils/otp'
 
 const MOCK_VALID_OTP = '123456'
 const MOCK_OTP_PREFIX = 'ABC'
+const ADMIN_LOGIN_SESSION_COOKIE_NAME = 'formsg.connect.sid'
 
 /**
  * Integration test helper to create an authenticated session where the user
@@ -50,7 +51,7 @@ export const createAuthedSession = async (
   // Assert
   // Should have session cookie returned.
   const sessionCookie = request.cookies.find(
-    (cookie) => cookie.name === 'formsg.connect.sid',
+    (cookie) => cookie.name === ADMIN_LOGIN_SESSION_COOKIE_NAME,
   )
   expect(sessionCookie).toBeDefined()
 
@@ -68,7 +69,7 @@ export const logoutSession = async (request: Session): Promise<Session> => {
   expect(response.status).toEqual(200)
 
   const sessionCookie = request.cookies.find(
-    (cookie) => cookie.name === 'formsg.connect.sid',
+    (cookie) => cookie.name === ADMIN_LOGIN_SESSION_COOKIE_NAME,
   )
   expect(sessionCookie).not.toBeDefined()
 

diff --git a/frontend/src/features/admin-form/settings/components/AuthSettingsSection/constants.ts b/frontend/src/features/admin-form/settings/components/AuthSettingsSection/constants.ts
@@ -1,4 +1,4 @@
-import { FormAuthType, FormResponseMode } from '~shared/types/form'
+import { FormAuthType } from '~shared/types/form'
 
 export type EmailFormAuthType = FormAuthType
 export type StorageFormAuthType = FormAuthType