chore: add lint rule to prevent floating promises (#404)

* chore: add lint rule to prevent floating promises

* fix: add await or void calls to floating promises

* feat(FormModel): await pre-validate hook

.eslintrc

@@ -21,7 +21,8 @@
         "sourceType": "module",
         "ecmaFeatures": {
           "modules": true
-        }
+        },
+        "project": "./tsconfig.json"
       },
       "plugins": ["@typescript-eslint", "import", "simple-import-sort"],
       "extends": ["plugin:@typescript-eslint/recommended"],
@@ -50,7 +51,8 @@
         "import/order": "off",
         "import/first": "error",
         "import/newline-after-import": "error",
-        "import/no-duplicates": "error"
+        "import/no-duplicates": "error",
+        "@typescript-eslint/no-floating-promises": 2,
       }
     },
     { "files": ["*.spec.ts"], "extends": ["plugin:jest/recommended"] }

src/app/models/form.server.model.ts

@@ -484,7 +484,7 @@ const compileFormModel = (db: Mongoose): IFormModel => {
   }
 
   // Hooks
-  FormSchema.pre<IFormSchema>('validate', function (next) {
+  FormSchema.pre<IFormSchema>('validate', async function (next) {
     // Reject save if form document is too large
     if (bson.calculateObjectSize(this) > 10 * MB) {
       const err = new Error('Form size exceeded.')
@@ -493,7 +493,7 @@ const compileFormModel = (db: Mongoose): IFormModel => {
     }
 
     // Validate that admin exists before form is created.
-    User.findById(this.admin, function (error, admin) {
+    await User.findById(this.admin, function (error, admin) {
       if (error) {
         return next(Error(`Error validating admin for form.`))
       }

src/app/modules/webhook/webhook.controller.ts

@@ -27,7 +27,7 @@ export const post = (
   if (webhookUrl) {
     // Note that we push data to webhook endpoints on a best effort basis
     // As such, we should not await on these post requests
-    pushData(webhookUrl, submissionWebhookView)
+    void pushData(webhookUrl, submissionWebhookView)
   }
   return next()
 }

src/loaders/mongoose.ts

@@ -97,7 +97,7 @@ export default async (): Promise<Connection> => {
       emailDomain: 'data.gov.sg',
       logo: '/public/modules/core/img/govtech.jpg',
     })
-    agency.save()
+    await agency.save()
   }
 
   return mongoose.connection

src/server.ts

@@ -21,4 +21,4 @@ const initServer = async () => {
   })
 }
 
-initServer()
+void initServer()